Sounds pause issue (iOS 7 bug) #1719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi Bruno, Thanks |
dingpinglv
added a commit
that referenced
this pull request
Mar 26, 2014
Sounds pause issue (iOS 7 bug)
dingpinglv
added a commit
to dingpinglv/cocos2d-html5
that referenced
this pull request
Mar 26, 2014
dingpinglv
added a commit
that referenced
this pull request
Mar 26, 2014
Issue #1719: added pageshow and pagehide events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that occasionally, on iOS 7, the visibilitychange event just doesn't get fired if you press the Home button when the game is active, so the sounds continued playing on background.
I don't know if that happens because I'm using a custom SoundEngine, based on Howler.js, but I guess that using the pagehide and pageshow events will do no harm, so here it is. I've added a check to prevent playing/pausing when unnecessary.