Skip to content

cc.LabelBMFont issues #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 24, 2014
Merged

cc.LabelBMFont issues #1714

merged 3 commits into from
Mar 24, 2014

Conversation

@bassarisse
Copy link
Contributor

@bassarisse bassarisse commented Mar 22, 2014

Label Test presented some issues on BMFontMultiLine2Test:

  • The first letter after a line break was disappearing
  • Empty lines were not being shown
  • The functions used to calculate if a letter passed the max width were messed up

This pull request fixes them.

@bassarisse
Copy link
Contributor Author

bassarisse commented Mar 22, 2014

I saw the multiline fix here: #844

@dingpinglv
Copy link
Contributor

dingpinglv commented Mar 24, 2014

Thank you very much, Bruno Assarisse.

dingpinglv added a commit that referenced this pull request Mar 24, 2014
@dingpinglv
Merge pull request #1714 from bassarisse/develop
90f1ec8 
cc.LabelBMFont issues
@dingpinglv dingpinglv merged commit 90f1ec8 into cocos2d:develop Mar 24, 2014
@dingpinglv dingpinglv mentioned this pull request Mar 24, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bassarisse @dingpinglv