DVCSMP-3664 Fix most common exceptions (SmartThingsCommunity#2911)

greens · web-flow · commit bb5e8ce3994d · 2018-03-14T14:51:13.000-07:00
* DVCSMP-3664 Fix most common exceptions

Code oversight in Z-Wave Controller.

Essentially an NPE in aeon home energy meter.
diff --git a/devicetypes/smartthings/aeon-home-energy-meter-c3.src/aeon-home-energy-meter-c3.groovy b/devicetypes/smartthings/aeon-home-energy-meter-c3.src/aeon-home-energy-meter-c3.groovy
@@ -97,7 +97,7 @@ def parse(String description) {
 	}
 	log.debug "Parse returned ${result?.descriptionText}"
 
-	storeGraphData(result.name, result.value)
+	if (result?.name && result.value) storeGraphData(result.name, result.value)
 
 	return result
 }
diff --git a/devicetypes/smartthings/zwave-controller.src/zwave-controller.groovy b/devicetypes/smartthings/zwave-controller.src/zwave-controller.groovy
@@ -79,7 +79,7 @@ def zwaveEvent(physicalgraph.zwave.commands.crc16encapv1.Crc16Encap cmd) {
 }
 
 def zwaveEvent(physicalgraph.zwave.Command cmd) {
-	createEvent(isStateChange: true, "$device.displayName: $cmd")
+	createEvent(isStateChange: true, descriptionText: "$device.displayName: $cmd")
 }
 
 def on() {

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ def parse(String description) {`
`97`	`97`	`}`
`98`	`98`	`log.debug "Parse returned ${result?.descriptionText}"`
`99`	`99`
`100`		`- storeGraphData(result.name, result.value)`
	`100`	`+ if (result?.name && result.value) storeGraphData(result.name, result.value)`
`101`	`101`
`102`	`102`	`return result`
`103`	`103`	`}`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ def zwaveEvent(physicalgraph.zwave.commands.crc16encapv1.Crc16Encap cmd) {`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`def zwaveEvent(physicalgraph.zwave.Command cmd) {`
`82`		`- createEvent(isStateChange: true, "$device.displayName: $cmd")`
	`82`	`+ createEvent(isStateChange: true, descriptionText: "$device.displayName: $cmd")`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`def on() {`