Skip to content

Commit 9b998d5

Browse files
committed
fix(clerk-js): Add localization keys to SignInFactorTwoAlternativeMethods
1 parent a5f5251 commit 9b998d5

File tree

4 files changed

+15
-17
lines changed

4 files changed

+15
-17
lines changed

packages/clerk-js/src/ui/SignIn/AlternativeMethods.tsx

+4-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,10 @@ const AlternativeMethodsList = (props: AlternativeMethodsProps & { onHavingTroub
5555
elementDescriptor={descriptors.main}
5656
gap={8}
5757
>
58-
<SignInSocialButtons />
58+
<SignInSocialButtons
59+
enableWeb3Providers
60+
enableOAuthProviders
61+
/>
5962
<Flex
6063
elementDescriptor={descriptors.alternativeMethods}
6164
direction='col'

packages/clerk-js/src/ui/SignIn/SignInFactorTwoAlternativeMethods.tsx

+10-11
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { SignInFactor } from '@clerk/types';
22
import React from 'react';
33

44
import { useCoreSignIn } from '../../ui/contexts/';
5-
import { descriptors, Flex, Flow } from '../customizables';
5+
import { Col, descriptors, Flow, localizationKeys } from '../customizables';
66
import { ArrowBlockButton, Card, CardAlert, Footer, Header } from '../elements';
77
import { useCardState } from '../elements/contexts';
88
import { formatSafeIdentifier } from '../utils';
@@ -41,18 +41,14 @@ const AlternativeMethodsList = (props: AlternativeMethodsProps & { onHavingTroub
4141
<CardAlert>{card.error}</CardAlert>
4242
<Header.Root>
4343
{onBackLinkClick && <Header.BackLink onClick={onBackLinkClick} />}
44-
<Header.Title>Use another method</Header.Title>
44+
<Header.Title localizationKey={localizationKeys('signIn.alternativeMethods.title')} />
4545
</Header.Root>
4646
{/*TODO: extract main in its own component */}
47-
<Flex
48-
direction='col'
47+
<Col
4948
elementDescriptor={descriptors.main}
5049
gap={8}
5150
>
52-
<Flex
53-
direction='col'
54-
gap={2}
55-
>
51+
<Col gap={2}>
5652
{supportedSecondFactors.map((factor, i) => (
5753
<ArrowBlockButton
5854
key={i}
@@ -62,11 +58,14 @@ const AlternativeMethodsList = (props: AlternativeMethodsProps & { onHavingTroub
6258
{getButtonLabel(factor)}
6359
</ArrowBlockButton>
6460
))}
65-
</Flex>
66-
</Flex>
61+
</Col>
62+
</Col>
6763
<Footer.Root>
6864
<Footer.Action>
69-
<Footer.ActionLink onClick={onHavingTroubleClick}>Get help</Footer.ActionLink>
65+
<Footer.ActionLink
66+
localizationKey={localizationKeys('signIn.alternativeMethods.actionLink')}
67+
onClick={onHavingTroubleClick}
68+
/>
7069
</Footer.Action>
7170
<Footer.Links />
7271
</Footer.Root>

packages/clerk-js/src/ui/SignUp/SignUpStart.tsx

+1-3
Original file line numberDiff line numberDiff line change
@@ -270,9 +270,7 @@ function _SignUpStart(): JSX.Element {
270270
<Footer.ActionLink
271271
localizationKey={localizationKeys('signUp.start.actionLink')}
272272
to={signInUrl}
273-
>
274-
Sign in
275-
</Footer.ActionLink>
273+
/>
276274
</Footer.Action>
277275
<Footer.Links />
278276
</Footer.Root>

packages/clerk-js/src/ui/elements/Footer.tsx

-2
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ const FooterAction = (props: React.PropsWithChildren<any>): JSX.Element => {
2828
const FooterActionText = (props: React.PropsWithChildren<any>): JSX.Element => {
2929
return (
3030
<Text
31-
localizationKey={descriptors.footerActionText.objectKey}
3231
elementDescriptor={descriptors.footerActionText}
3332
{...props}
3433
as='span'
@@ -41,7 +40,6 @@ const FooterActionText = (props: React.PropsWithChildren<any>): JSX.Element => {
4140
const FooterActionLink = (props: PropsOfComponent<typeof RouterLink>): JSX.Element => {
4241
return (
4342
<RouterLink
44-
localizationKey={descriptors.footerActionLink.objectKey}
4543
elementDescriptor={descriptors.footerActionLink}
4644
{...props}
4745
colorScheme='primary'

0 commit comments

Comments
 (0)