Skip to content

Commit 2ec9f6b

Browse files
fix(shared): Ensure window object existence (#2913)
* fix(shared): Ensure window object existence before accessing its properties * add changeset --------- Co-authored-by: Lennart <lekoarts@gmail.com>
1 parent f02482b commit 2ec9f6b

File tree

3 files changed

+63
-58
lines changed

3 files changed

+63
-58
lines changed

.changeset/rude-plums-move.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@clerk/shared": patch
3+
---
4+
5+
Ensure that inside `isValidBrowser()` and `isBrowserOnline()` the existence of `window` is checked before trying to access `window.navigator`

package-lock.json

+54-54
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/shared/src/browser.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ export function userAgentIsRobot(userAgent: string): boolean {
5252
* @returns {boolean}
5353
*/
5454
export function isValidBrowser(): boolean {
55-
const navigator = window?.navigator;
56-
if (!inBrowser() || !navigator) {
55+
const navigator = inBrowser() ? window?.navigator : null;
56+
if (!navigator) {
5757
return false;
5858
}
5959
return !userAgentIsRobot(navigator?.userAgent) && !navigator?.webdriver;
@@ -64,8 +64,8 @@ export function isValidBrowser(): boolean {
6464
* @returns {boolean}
6565
*/
6666
export function isBrowserOnline(): boolean {
67-
const navigator = window?.navigator;
68-
if (!inBrowser() || !navigator) {
67+
const navigator = inBrowser() ? window?.navigator : null;
68+
if (!navigator) {
6969
return false;
7070
}
7171

0 commit comments

Comments
 (0)