Skip to content

Commit 45acc2d

Browse files
committed
Fix secrects injection in GitHub Actions
1 parent 5b73707 commit 45acc2d

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

.github/workflows/deploying.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@ jobs:
5959
env:
6060
APPLE_ID: ${{ secrets.APPLE_ID }}
6161
APP_IDENTIFIER: ${{ secrets.APP_IDENTIFIER }}
62+
APP_STORE_CONNECT_API_KEY_KEY_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY_ID }}
63+
APP_STORE_CONNECT_API_KEY_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }}
64+
APP_STORE_CONNECT_API_KEY_KEY_CONTENT: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY_CONTENT }}
6265
DESTINATION_EMAIL: ${{ secrets.DESTINATION_EMAIL }}
6366
EMAIL_FROM_NAME: ${{ secrets.EMAIL_FROM_NAME }}
6467
EMAIL_REPLY_TO: ${{ secrets.EMAIL_REPLY_TO }}

fastlane/Fastfile

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
11
default_platform :ios
2-
api_key = app_store_connect_api_key(
3-
key_id: ENV["APP_STORE_CONNECT_API_KEY_KEY_ID"],
4-
issuer_id: ENV["APP_STORE_CONNECT_API_KEY_ISSUER_ID"],
5-
key_content: ENV["APP_STORE_CONNECT_API_KEY_KEY_CONTENT"],
6-
)
72

83
lane :prepare do
94
carthage(cache_builds: true, platform: "iOS")
@@ -75,6 +70,11 @@ platform :ios do
7570
desc "This will also make sure the profile is up to date"
7671
lane :beta do
7772
app_identifier = "me.mssun.passforiosbeta"
73+
api_key = app_store_connect_api_key(
74+
key_id: ENV["APP_STORE_CONNECT_API_KEY_KEY_ID"],
75+
issuer_id: ENV["APP_STORE_CONNECT_API_KEY_ISSUER_ID"],
76+
key_content: ENV["APP_STORE_CONNECT_API_KEY_KEY_CONTENT"]
77+
)
7878

7979
if is_ci?
8080
create_keychain(
@@ -129,6 +129,11 @@ platform :ios do
129129
desc "Submit a new build to AppStore"
130130
lane :release do
131131
app_identifier = "me.mssun.passforios"
132+
api_key = app_store_connect_api_key(
133+
key_id: ENV["APP_STORE_CONNECT_API_KEY_KEY_ID"],
134+
issuer_id: ENV["APP_STORE_CONNECT_API_KEY_ISSUER_ID"],
135+
key_content: ENV["APP_STORE_CONNECT_API_KEY_KEY_CONTENT"]
136+
)
132137

133138
if is_ci?
134139
create_keychain(

0 commit comments

Comments
 (0)