hubble: remove deprecated experimental fieldmask #40245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaworu
added
kind/enhancement
kaworu
force-pushed
the
pr/kaworu/hubble/remove-exp-fieldmask
branch
from
02e9576 to
8a24d9e
Compare
kaworu
commented
Jun 27, 2025
michi-covalent
approved these changes
Jun 27, 2025
Contributor
michi-covalent
left a comment
michi-covalent
left a comment
There was a problem hiding this comment.
proto file change looks good ✅
joestringer
removed
the
dont-merge/wait-until-release
kaworu
force-pushed
the
pr/kaworu/hubble/remove-exp-fieldmask
branch
from
8a24d9e to
42d6dcc
Compare
glrf
approved these changes
Jul 9, 2025
kaworu
force-pushed
the
pr/kaworu/hubble/remove-exp-fieldmask
branch
from
42d6dcc to
911a54f
Compare
kaworu
force-pushed
the
pr/kaworu/hubble/remove-exp-fieldmask
branch
2 times, most recently
from
159eeb5 to
697daaa
Compare
qmonnet
approved these changes
Jul 30, 2025
kaworu
force-pushed
the
pr/kaworu/hubble/remove-exp-fieldmask
branch
from
697daaa to
f3ee211
Compare
Member
Author
|
/test |
Member
Author
|
Restarting |
kaworu
added
the
dont-merge/needs-rebase
devodev
approved these changes
Aug 11, 2025
kaworu
force-pushed
the
pr/kaworu/hubble/remove-exp-fieldmask
branch
from
f3ee211 to
ceeb4c1
Compare
kaworu
removed
the
dont-merge/needs-rebase
Member
Author
|
/test |
kaworu
force-pushed
the
pr/kaworu/hubble/remove-exp-fieldmask
branch
from
ceeb4c1 to
426c430
Compare
Contributor
|
/test |
Hubble clients can request a subset of flow fields through FieldMask, allowing some control over the bandwidth used by the response. Since cilium#30133 FieldMask has been promoted to stable, and its experimental option has been deprecated. This commit remove the experimental FieldMask option. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
Also rename the related --experimental-use-default-field-masks flag to to --use-default-field-masks. Since GetFlowsRequest.field_mask is now stable, stabilize the Hubble CLI related flags. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
Signed-off-by: Alexandre Perrin <alex@isovalent.com>
kaworu
force-pushed
the
pr/kaworu/hubble/remove-exp-fieldmask
branch
from
426c430 to
18de923
Compare
Member
Author
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promote the CLI fieldmask related flags to stable on the way, and make
--use-default-field-masksthe default. To be merged after v1.18 so we have some time to test the--use-default-field-maskschange.Still TODO: update upgrade.rst to document the CLI and API changes.Closes #40235