-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Labels
area/eniImpacts ENI based IPAM.Impacts ENI based IPAM.help-wantedPlease volunteer for this by adding yourself as an assignee!Please volunteer for this by adding yourself as an assignee!integration/cloudRelated to integration with cloud environments such as AKS, EKS, GKE, etc.Related to integration with cloud environments such as AKS, EKS, GKE, etc.sig/scalabilityImpacts how well Cilium handles a high rate of events or churn.Impacts how well Cilium handles a high rate of events or churn.
Description
I've been talking offline a little bit with @antonipp about #39543 and newly introduced flag --aws-pagination-enabled
To summarize our discussion:
- In case of listing interfaces, there is no clear number/limit of interfaces at which
DescribeNetworkInterfacesfails with errorOperationNotPermittedfor calls without pagination. - Paginated results are usually significantly slower + they use API more heavily, potentially resulting in more throttling
Proposed improvement:
Instead of always using paginated or unpaginated API calls, let's always try unpaginated request and only if it fails (for any reason), try paginated api calls.
This has following benefits:
- In happy case (unpaginated call works) it's fast
- No need to have additional flag - easier from operational point of view
- Paginated api calls sometimes do not have a predictable performance: operator: add flag to control AWS API pagination #39543 (comment)
- Unpaginated API Calls for interfaces should work almost always if
subnet-id/subnet-tagsis specified (to be verified)
And small drawback: - If unpaginated call didn't work, we did performed only one unnecessary API call out of tens of paginated API calls
This sounds like a good trade off to me, but I would appreciate others' feedback as well.
joestringer
Metadata
Metadata
Assignees
Labels
area/eniImpacts ENI based IPAM.Impacts ENI based IPAM.help-wantedPlease volunteer for this by adding yourself as an assignee!Please volunteer for this by adding yourself as an assignee!integration/cloudRelated to integration with cloud environments such as AKS, EKS, GKE, etc.Related to integration with cloud environments such as AKS, EKS, GKE, etc.sig/scalabilityImpacts how well Cilium handles a high rate of events or churn.Impacts how well Cilium handles a high rate of events or churn.