Rename command helper to execute

Since we have already changed the signature of this helper in a previous
commit, rename it to further emphasize the difference, as well as make
the method name more verb-like.

Change-Id: Ie768052999d69c03943020b90eaccce9f2ecdb8b
Reviewed-on: http://gerrit.causes.com/36001
Tested-by: jenkins <jenkins@causes.com>
Reviewed-by: Shane da Silva <shane@causes.com>

Author: Shane da Silva

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 * Change `command` hook helper signature to accept an array of arguments
   instead of a shell string
+* Rename `command` hook helper to `execute`
 * Add support for JRuby 1.7.9 in Ruby 1.9 mode
 
 ## 0.6.3

lib/overcommit/hook/base.rb

@@ -51,8 +51,8 @@ def in_path?(cmd)
       Overcommit::Utils.in_path?(cmd)
     end
 
-    def command(cmd)
-      Overcommit::Utils.command(cmd)
+    def execute(cmd)
+      Overcommit::Utils.execute(cmd)
     end
 
     # Gets a list of staged files that apply to this hook based on its

lib/overcommit/hook/commit_msg/gerrit_change_id.rb

@@ -7,7 +7,7 @@ module Overcommit::Hook::CommitMsg
   # edit the message after a prepare-commit-msg hook was run.
   class GerritChangeId < Base
     def run
-      result = command([SCRIPT_LOCATION, commit_message_file])
+      result = execute([SCRIPT_LOCATION, commit_message_file])
       return (result.success? ? :good : :bad), result.stdout
     end
 

lib/overcommit/hook/post_checkout/bundle_check.rb

@@ -15,15 +15,15 @@ def run
   private
 
     def dependencies_changed?
-      result = command(%w[git diff --exit-code --name-only] + [new_head, previous_head])
+      result = execute(%w[git diff --exit-code --name-only] + [new_head, previous_head])
 
       result.stdout.split("\n").any? do |file|
         Array(@config['include']).any? { |glob| File.fnmatch(glob, file) }
       end
     end
 
     def dependencies_satisfied?
-      command(%w[bundle check]).success?
+      execute(%w[bundle check]).success?
     end
   end
 end

lib/overcommit/hook/pre_commit/author_email.rb

@@ -2,7 +2,7 @@ module Overcommit::Hook::PreCommit
   # Checks the format of an author's email address.
   class AuthorEmail < Base
     def run
-      result = command(%w[git config --get user.email])
+      result = execute(%w[git config --get user.email])
       email = result.stdout.chomp
 
       unless email =~ /#{@config['pattern']}/

lib/overcommit/hook/pre_commit/author_name.rb

@@ -2,7 +2,7 @@ module Overcommit::Hook::PreCommit
   # Ensures that a commit author has a name with at least first and last names.
   class AuthorName < Base
     def run
-      result = command(%w[git config --get user.name])
+      result = execute(%w[git config --get user.name])
       name = result.stdout.chomp
 
       unless name.split(' ').count >= 2

lib/overcommit/hook/pre_commit/bundle_check.rb

@@ -8,14 +8,14 @@ def run
       end
 
       # Ignore if Gemfile.lock is not tracked by git
-      return :good if command(%w[git check-ignore] + [LOCK_FILE]).success?
+      return :good if execute(%w[git check-ignore] + [LOCK_FILE]).success?
 
-      result = command(%w[bundle check])
+      result = execute(%w[bundle check])
       unless result.success?
         return :bad, result.stdout
       end
 
-      result = command(%w[git diff --quiet --] + [LOCK_FILE])
+      result = execute(%w[git diff --quiet --] + [LOCK_FILE])
       unless result.success?
         return :bad, "#{LOCK_FILE} is not up-to-date -- run `bundle check`"
       end

lib/overcommit/hook/pre_commit/coffee_lint.rb

@@ -6,7 +6,7 @@ def run
         return :warn, 'Run `npm install -g coffeelint`'
       end
 
-      result = command(%w[coffeelint --quiet] + applicable_files)
+      result = execute(%w[coffeelint --quiet] + applicable_files)
       return :good if result.success?
       return :bad, result.stdout
     end

lib/overcommit/hook/pre_commit/css_lint.rb

@@ -6,7 +6,7 @@ def run
         return :warn, 'csslint not installed -- run `npm install -g csslint`'
       end
 
-      result = command(%w[csslint --quiet --format=compact] + applicable_files)
+      result = execute(%w[csslint --quiet --format=compact] + applicable_files)
       output = result.stdout
       return (output !~ /Error - (?!Unknown @ rule)/ ? :good : :bad), output
     end

lib/overcommit/hook/pre_commit/haml_lint.rb

@@ -6,7 +6,7 @@ def run
         return :warn, 'haml-lint not installed -- run `gem install haml-lint`'
       end
 
-      result = command(%w[haml-lint] + applicable_files)
+      result = execute(%w[haml-lint] + applicable_files)
       return :good if result.success?
 
       # Keep lines from the output for files that we actually modified

lib/overcommit/hook/pre_commit/hard_tabs.rb

@@ -3,7 +3,7 @@ module Overcommit::Hook::PreCommit
   class HardTabs < Base
     def run
       # Catches hard tabs
-      result = command(%w[grep -IHn] + ["\t"] + applicable_files)
+      result = execute(%w[grep -IHn] + ["\t"] + applicable_files)
       unless result.stdout.empty?
         return :bad, "Hard tabs detected:\n#{result.stdout}"
       end

lib/overcommit/hook/pre_commit/js_hint.rb

@@ -6,7 +6,7 @@ def run
         return :warn, 'jshint not installed -- run `npm install -g jshint`'
       end
 
-      result = command(%w[jshint] + applicable_files)
+      result = execute(%w[jshint] + applicable_files)
       output = result.stdout
 
       return (output.empty? ? :good : :bad), output

lib/overcommit/hook/pre_commit/jscs.rb

@@ -7,7 +7,7 @@ def run
         return :warn, 'jscs not installed -- run `npm install -g jscs`'
       end
 
-      result = command(%w[jscs --reporter=inline] + applicable_files)
+      result = execute(%w[jscs --reporter=inline] + applicable_files)
       return :good if result.success?
 
       if /Config.*not found/i =~ result.stderr

lib/overcommit/hook/pre_commit/python_flake8.rb

@@ -6,7 +6,7 @@ def run
         return :warn, 'flake8 not installed -- run `pip install flake8`'
       end
 
-      result = command(%w[flake8] + applicable_files)
+      result = execute(%w[flake8] + applicable_files)
 
       return (result.success? ? :good : :bad), result.stdout
     end

lib/overcommit/hook/pre_commit/rubocop.rb

@@ -6,7 +6,7 @@ def run
         return :warn, 'Rubocop not installed -- run `gem install rubocop`'
       end
 
-      result = command(%w[rubocop --format=emacs] + applicable_files)
+      result = execute(%w[rubocop --format=emacs] + applicable_files)
       return :good if result.success?
 
       output = result.stdout + result.stderr

lib/overcommit/hook/pre_commit/scss_lint.rb

@@ -6,7 +6,7 @@ def run
         return :warn, 'scss-lint not installed -- run `gem install scss-lint`'
       end
 
-      result = command(%w[scss-lint] + applicable_files)
+      result = execute(%w[scss-lint] + applicable_files)
       return :good if result.success?
 
       # Keep lines from the output for files that we actually modified

lib/overcommit/hook/pre_commit/trailing_whitespace.rb

@@ -2,7 +2,7 @@ module Overcommit::Hook::PreCommit
   # Checks for trailing whitespace in files.
   class TrailingWhitespace < Base
     def run
-      result = command(%w[grep -IHn \s$] + applicable_files)
+      result = execute(%w[grep -IHn \s$] + applicable_files)
       unless result.stdout.empty?
         return :bad, "Trailing whitespace detected:\n#{result.stdout}"
       end

lib/overcommit/utils.rb

@@ -62,7 +62,7 @@ def in_path?(cmd)
       # Overcommit to call other Ruby executables without requiring that they be
       # specified in Overcommit's Gemfile--a nasty consequence of using
       # `bundle exec overcommit` while developing locally.
-      def command(args)
+      def execute(args)
         with_environment 'RUBYOPT' => nil do
           Subprocess.spawn(args)
         end

spec/overcommit/hook/pre_commit/author_email_spec.rb

@@ -8,7 +8,7 @@
 
   before do
     result.stub(:stdout).and_return(email)
-    subject.stub(:command).and_return(result)
+    subject.stub(:execute).and_return(result)
   end
 
   context 'when user has no email' do

spec/overcommit/hook/pre_commit/author_name_spec.rb

@@ -8,7 +8,7 @@
 
   before do
     result.stub(:stdout).and_return(name)
-    subject.stub(:command).and_return(result)
+    subject.stub(:execute).and_return(result)
   end
 
   context 'when user has no name' do

spec/overcommit/hook/pre_commit/bundle_check_spec.rb

@@ -37,8 +37,8 @@
 
     before do
       result.stub(:success? => success, :stdout => 'Bundler error message')
-      subject.stub(:command).and_call_original
-      subject.stub(:command).with(%w[bundle check]).and_return(result)
+      subject.stub(:execute).and_call_original
+      subject.stub(:execute).with(%w[bundle check]).and_return(result)
     end
 
     context 'and bundle check exits unsuccessfully' do

spec/overcommit/hook/pre_commit/coffee_lint_spec.rb

@@ -22,7 +22,7 @@
     before do
       result = double('result')
       result.stub(:success?).and_return(true)
-      subject.stub(:command).and_return(result)
+      subject.stub(:execute).and_return(result)
     end
 
     it { should pass }
@@ -33,7 +33,7 @@
       result = double('result')
       result.stub(:success?).and_return(false)
       result.stub(:stdout)
-      subject.stub(:command).and_return(result)
+      subject.stub(:execute).and_return(result)
     end
 
     it { should fail_check }

spec/overcommit/hook/pre_commit/css_lint_spec.rb

@@ -22,7 +22,7 @@
     before do
       result = double('result')
       result.stub(:stdout).and_return('')
-      subject.stub(:command).and_return(result)
+      subject.stub(:execute).and_return(result)
     end
 
     it { should pass }
@@ -32,7 +32,7 @@
     before do
       result = double('result')
       result.stub(:stdout).and_return('Error - @charset not allowed here')
-      subject.stub(:command).and_return(result)
+      subject.stub(:execute).and_return(result)
     end
 
     it { should fail_check }

spec/overcommit/hook/pre_commit/haml_lint_spec.rb

@@ -22,7 +22,7 @@
     before do
       result = double('result')
       result.stub(:success?).and_return(true)
-      subject.stub(:command).and_return(result)
+      subject.stub(:execute).and_return(result)
     end
 
     it { should pass }
@@ -33,7 +33,7 @@
 
     before do
       result.stub(:success?).and_return(false)
-      subject.stub(:command).and_return(result)
+      subject.stub(:execute).and_return(result)
     end
 
     context 'and it reports lines that were not modified by the commit' do

spec/overcommit/hook/pre_commit/js_hint_spec.rb

@@ -22,7 +22,7 @@
     before do
       result = double('result')
       result.stub(:stdout).and_return('')
-      subject.stub(:command).and_return(result)
+      subject.stub(:execute).and_return(result)
     end
 
     it { should pass }
@@ -32,7 +32,7 @@
     before do
       result = double('result')
       result.stub(:stdout).and_return('Undefined variable')
-      subject.stub(:command).and_return(result)
+      subject.stub(:execute).and_return(result)
     end
 
     it { should fail_check }

spec/overcommit/hook/pre_commit/jscs_spec.rb

@@ -23,7 +23,7 @@
       result = double('result')
       result.stub(:success? => false,
                   :stderr => 'Configuration file some-path/.jscs.json was not found.')
-      subject.stub(:command).and_return(result)
+      subject.stub(:execute).and_return(result)
     end
 
     it { should warn }
@@ -34,7 +34,7 @@
 
     before do
       result.stub(:success? => false, :stderr => '')
-      subject.stub(:command).and_return(result)
+      subject.stub(:execute).and_return(result)
     end
 
     context 'and it reports lines that were not modified by the commit' do

spec/overcommit/hook/pre_commit/python_flake8_spec.rb

@@ -23,7 +23,7 @@
       result = double('result')
       result.stub(:success?).and_return(true)
       result.stub(:stdout)
-      subject.stub(:command).and_return(result)
+      subject.stub(:execute).and_return(result)
     end
 
     it { should pass }
@@ -34,7 +34,7 @@
       result = double('result')
       result.stub(:success?).and_return(false)
       result.stub(:stdout)
-      subject.stub(:command).and_return(result)
+      subject.stub(:execute).and_return(result)
     end
 
     it { should fail_check }

spec/overcommit/hook/pre_commit/rubocop_spec.rb

@@ -22,7 +22,7 @@
     before do
       result = double('result')
       result.stub(:success?).and_return(true)
-      subject.stub(:command).and_return(result)
+      subject.stub(:execute).and_return(result)
     end
 
     it { should pass }
@@ -33,7 +33,7 @@
 
     before do
       result.stub(:success?).and_return(false)
-      subject.stub(:command).and_return(result)
+      subject.stub(:execute).and_return(result)
     end
 
     context 'and it reports lines that were not modified by the commit' do

spec/overcommit/hook/pre_commit/scss_lint_spec.rb

@@ -22,7 +22,7 @@
     before do
       result = double('result')
       result.stub(:success?).and_return(true)
-      subject.stub(:command).and_return(result)
+      subject.stub(:execute).and_return(result)
     end
 
     it { should pass }
@@ -33,7 +33,7 @@
 
     before do
       result.stub(:success?).and_return(false)
-      subject.stub(:command).and_return(result)
+      subject.stub(:execute).and_return(result)
     end
 
     context 'and it reports lines that were not modified by the commit' do