Introduce: "Unauthenticated rate limited requests"

Author: stloyd

lib/Github/Client.php

@@ -22,6 +22,12 @@ class Client
      */
     const AUTH_URL_TOKEN = 'url_token';
 
+    /**
+     * Constant for authentication method. Not indicates the new login, but allows
+     * usage of unauthenticated rate limited requests for given client_id + client_secret
+     */
+    const AUTH_URL_CLIENT_ID = 'url_client_id';
+
     /**
      * Constant for authentication method. Indicates the new favored login method
      * with username and password via HTTP Authentication.
@@ -76,7 +82,7 @@ public function authenticate($login, $secret = null, $method = null)
     {
         $this->getHttpClient()->setOption('auth_method', $method);
 
-        if ($method === self::AUTH_HTTP_PASSWORD) {
+        if ($method === self::AUTH_HTTP_PASSWORD || $method === self::AUTH_URL_CLIENT_ID) {
             $this
                 ->getHttpClient()
                 ->setOption('login', $login)

lib/Github/HttpClient/Listener/AuthListener.php

@@ -61,21 +61,41 @@ public function preSend(RequestInterface $request)
                 $request->addHeader('Authorization: token '. $this->options['token']);
                 break;
 
+            case Client::AUTH_URL_CLIENT_ID:
+                if (!isset($this->options['login'], $this->options['password'])) {
+                    throw new InvalidArgumentException('You need to set client_id and client_secret!');
+                }
+
+                if ('GET' === $request->getMethod()) {
+                    $url = $request->getUrl();
+
+                    $parameters = array(
+                        'client_id'     => $this->options['login'],
+                        'client_secret' => $this->options['password'],
+                    );
+
+                    $url .= (false === strpos($url, '?') ? '?' : '&').utf8_encode(http_build_query($parameters, '', '&'));
+
+                    $request->fromUrl(new Url($url));
+                }
+                break;
+
             case Client::AUTH_URL_TOKEN:
                 if (!isset($this->options['token'])) {
                     throw new InvalidArgumentException('You need to set OAuth token!');
                 }
-                $url = $request->getUrl();
 
                 if ('GET' === $request->getMethod()) {
+                    $url = $request->getUrl();
+
                     $parameters = array(
                         'access_token' => $this->options['token']
                     );
 
-                    $url .= '?'.utf8_encode(http_build_query($parameters, '', '&'));
-                }
+                    $url .= (false === strpos($url, '?') ? '?' : '&').utf8_encode(http_build_query($parameters, '', '&'));
 
-                $request->fromUrl(new Url($url));
+                    $request->fromUrl(new Url($url));
+                }
                 break;
         }
     }