Commit 05a3319
committed
provide a better missing error message
When github say's missing, it's not talking about the resource - it
means something referenced in the data.
For example, specifying a milestone that doesn't exist will return:
```
{
"message": "Validation Failed"
"documentation_url": "http"://developer.github.com/v3"
"errors": [
{
"value": 42,
"resource": "Issue",
"field": "milestone",
"code": "missing"
}
]
}
```
Previously this would be reported as:
> Validation Failed: Resource "Issue" not exists anymore
Now it's reported as
> The milestone 42 doesa not exist, for resource "Issue"1 parent 3787a1b commit 05a3319
File tree
2 files changed
+2
-1
lines changed- lib/Github/HttpClient/Listener
- test/Github/Tests/HttpClient/Listener
2 files changed
+2
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
| 60 | + | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
| 127 | + | |
127 | 128 | | |
128 | 129 | | |
129 | 130 | | |
| |||
0 commit comments