Skip to content

Commit b0e68c4

Browse files
Escape & in url to make it work (hopefully)
1 parent 79f7c93 commit b0e68c4

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.github/workflows/draft-new-release.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ jobs:
88
draft-new-release:
99
name: "Draft a new release"
1010
runs-on: ubuntu-latest
11-
if: startsWith(github.event.issue.title, 'Release version') && contains(github.event.issue.labels.*.name, 'release') # only run for issues with a specific title and label
11+
# Only run for issues with a specific title and label. Not strictly required but makes finding the release issue again later easier.
12+
if: startsWith(github.event.issue.title, 'Release version') && contains(github.event.issue.labels.*.name, 'release')
1213
steps:
1314
- uses: actions/checkout@v2
1415

@@ -62,7 +63,7 @@ jobs:
6263
# We are claiming things here based on the `publish-new-release.yml` workflow.
6364
# You should obviously adopt it to say the truth depending on your release workflow :)
6465
body: |
65-
Hi ${{ github.event.issue.user.login }}!
66+
Hi @${{ github.event.issue.user.login }}!
6667
6768
This PR was created in response to this release issue: #${{ github.event.issue.number }}.
6869
I've updated the changelog and bumped the versions in the manifest files in this commit: ${{ steps.make-commit.outputs.commit }}.

.github/workflows/publish-new-release.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@ jobs:
3434
# Hence, we close it here "manually"
3535
- name: Close release issue
3636
run: |
37-
38-
RELEASE_ISSUE_URL=$(curl https://api.github.com/repos/${{ github.repository }}/issues?labels=release&state=open | jq -r '.[1].url')
37+
RELEASE_ISSUE_URL=$(curl https://api.github.com/repos/${{ github.repository }}/issues\?labels=release\&state=open | jq -r '.[0].url')
3938
4039
curl \
4140
-X PATCH \

0 commit comments

Comments
 (0)