Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cadence-workflow/cadence-java-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: cadence-workflow/cadence-java-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.13.x
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 7 files changed
  • 1 contributor

Commits on Nov 18, 2025

  1. Make Proto Mappers Unopinionated (#1038) 

    Proto objects throw a NullPointerException if you pass a null value into any setFoo method. Our current mappers make strong assumptions about what fields are and aren't necessary, and any time they don't match either the server or the client logic we get a vague NullPointerException.

Instead, map all objects and don't assume that any field is non-null. The server or client should enforce the validity of the requests rather than the mapper.

Additionally don't mutate Maps that we receive from Thrift/Proto in WorkflowContext.
    @natemort
    natemort authored Nov 18, 2025
    Configuration menu
    Copy the full SHA
    4d2f165 View commit details
    Browse the repository at this point in the history

  2. Support gRPC Headers from ClientOptions and correct Scope Handling (#… 

    …1039)

Allow additional headers to be added via ClientOptions, similar to TChannel. Additionally support removing headers by setting built-in headers values to null or an empty string.

Refactor OpenTracingInterceptor to a separate file and correct Scope handling to resolve Context mismatches. Leaving the Scope open during initialization and then closing it during onClose is incorrect and can cause issues with other interceptors. It's difficult to test this change in isolation.
    @natemort
    natemort authored Nov 18, 2025
    Configuration menu
    Copy the full SHA
    03aaf14 View commit details
    Browse the repository at this point in the history
Loading