Skip to content

Commit 78109f3

Browse files
author
Mateusz Zajac
committedAug 26, 2015
Introduce some on purpose errors
1 parent c12deca commit 78109f3

File tree

5 files changed

+46
-3
lines changed

5 files changed

+46
-3
lines changed
 

‎XcodeServerSDK/API Routes/XcodeServer+Integration.swift

+32
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,38 @@ extension XcodeServer {
193193

194194
}
195195

196+
/**
197+
XCS API call for fetching all commits for specific integration.
198+
199+
- parameter integrationId: ID of integration.
200+
- parameter success: Optional Integration Issues object with result.
201+
- parameter error: Optional operation error.
202+
*/
203+
public final func getIntegrationIssues(integrationId: String, completion: (integrationIssues: IntegrationIssues?, error: ErrorType?) ->()) {
204+
205+
let params = [
206+
"integration": integrationId
207+
]
208+
209+
self.sendRequestWithMethod(.GET, endpoint: .Issues, params: params, query: nil, body: nil) { (response, body, error) -> () in
210+
211+
guard error == nil else {
212+
completion(integrationIssues: nil, error: error)
213+
return
214+
}
215+
216+
guard let integrationIssuesBody = (body as? NSDictionary)?["results"] as? NSArray else {
217+
completion(integrationIssues: nil, error: Error.withInfo("Wrong body \(body)"))
218+
return
219+
}
220+
221+
let integrationIssues = IntegrationIssues(json: integrationIssuesBody[0] as! NSDictionary)
222+
completion(integrationIssues: integrationIssues, error: nil)
223+
224+
}
225+
226+
}
227+
196228
// TODO: Methods about to be implemented...
197229

198230
// public func reportQueueSizeAndEstimatedWaitingTime(integration: Integration, completion: ((queueSize: Int, estWait: Double), NSError?) -> ()) {

‎XcodeServerSDK/Server Entities/IntegrationIssues.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import Foundation
1010
import BuildaUtils
1111

12-
public class IntegrationsIssue: XcodeServerEntity {
12+
public class IntegrationIssues: XcodeServerEntity {
1313

1414
public let buildServiceErrors: [Issue]
1515
public let buildServiceWarnings: [Issue]

‎XcodeServerSDK/XcodeServer.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
//
88

99
import Foundation
10-
import BuildaUtils
10+
import BuildaUtil
1111

1212
// MARK: XcodeServer Class
1313
public class XcodeServer : CIServer {

‎XcodeServerSDKTests/IntegrationTests.swift

+10
Original file line numberDiff line numberDiff line change
@@ -59,4 +59,14 @@ class IntegrationTests: XCTestCase {
5959

6060
}
6161

62+
// MARK: Issues
63+
64+
func testGetIntegrationIssues() {
65+
66+
let exp = self.expectationWithDescription("Network")
67+
let server = self.getRecordingXcodeServer("get_integration_issues")
68+
server.getIntegrationIssues(<#T##integrationId: String##String#>, completion: <#T##(integrationIssues: IntegrationIssues?, error: ErrorType?) -> ()#>)
69+
70+
}
71+
6272
}

‎XcodeServerSDKTests/IssueTests.swift

+2-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ class IssueTests: XCTestCase {
8585

8686
func testCommitsArray() {
8787
// Build Service Error doesn't have commits
88-
XCTAssertTrue(buildServiceError.commits.isEmpty)
88+
// XCTAssertTrue(buildServiceError.commits.isEmpty)
89+
XCTAssertFalse(buildServiceError.commits.isEmpty)
8990

9091
// Error, on the other hand, has one...
9192
XCTAssertEqual(errorWithCommits.commits.count, 1)

0 commit comments

Comments
 (0)