Move request options object into the options parameter, rename rej

Author: John McCambridge

packages/server/src/updater.ts

@@ -1,38 +1,16 @@
 import * as https from "https";
 
-export const compareVersions = (a: string, b: string): number | undefined => {
-	if (a === b) {
-		return 0;
-	}
-	const regEx = /[^0-9.]/g;
-	const aSplit = a.replace(regEx, "").split(".");
-	const bSplit = b.replace(regEx, "").split(".");
-	const dist = Math.max(aSplit.length, bSplit.length);
-	for (let i = 0; i < dist; i++) {
-		const aVal = parseInt(aSplit[i], 10);
-		const bVal = parseInt(bSplit[i], 10);
-		if (aVal > bVal || isNaN(bVal)) {
-			return 1;
-		}
-		if (aVal < bVal || isNaN(aVal)) {
-			return -1;
-		}
-	}
-};
-
 export const getRecentRelease = (): Promise<string> => {
 	return new Promise<string>((resolve, reject):void  => {
-		const options = {
+		https.get({
 			host: "api.github.com",
 			path: "/repos/codercom/code-server/releases/latest",
 			method: "GET",
 			agent: false,
 			headers: {
 				"User-Agent": "code-server",
 			},
-		};
-
-		https.get(options, (res) => {
+		}, (res) => {
 			if (res.statusCode !== 200) {
 				reject(Error("Failed to acquire release information"));
 			}