Set browsers automatically if not an interactive terminal

Author: Timer

packages/react-dev-utils/browsersHelper.js

@@ -15,7 +15,26 @@ const fs = require('fs');
 
 const defaultBrowsers = ['>0.25%', 'not op_mini all', 'ie 11'];
 
-function checkBrowsers(dir, retry = true) {
+function shouldSetBrowsers(isInteractive) {
+  if (!isInteractive) {
+    return Promise.resolve(true);
+  }
+
+  const question = {
+    type: 'confirm',
+    name: 'shouldSetBrowsers',
+    message:
+      chalk.yellow("We're unable to detect target browsers.") +
+      `\n\nWould you like to add the defaults to your ${chalk.bold(
+        'package.json'
+      )}?`,
+    default: true,
+  };
+
+  return inquirer.prompt(question).then(answer => answer.shouldSetBrowsers);
+}
+
+function checkBrowsers(dir, isInteractive, retry = true) {
   const current = browserslist.findConfig(dir);
   if (current != null) {
     return Promise.resolve(current);
@@ -35,44 +54,34 @@ function checkBrowsers(dir, retry = true) {
     );
   }
 
-  const question = {
-    type: 'confirm',
-    name: 'shouldSetBrowsers',
-    message:
-      chalk.yellow("We're unable to detect target browsers.") +
-      `\n\nWould you like to add the defaults to your ${chalk.bold(
-        'package.json'
-      )}?`,
-    default: true,
-  };
-  return inquirer.prompt(question).then(answer => {
-    if (answer.shouldSetBrowsers) {
-      return (
-        pkgUp(dir)
-          .then(filePath => {
-            if (filePath == null) {
-              return Promise.reject();
-            }
-            const pkg = JSON.parse(fs.readFileSync(filePath));
-            pkg['browserslist'] = defaultBrowsers;
-            fs.writeFileSync(filePath, JSON.stringify(pkg, null, 2) + os.EOL);
-
-            browserslist.clearCaches();
-            console.log();
-            console.log(
-              `${chalk.green('Set target browsers:')} ${chalk.cyan(
-                defaultBrowsers.join(', ')
-              )}`
-            );
-            console.log();
-          })
-          // Swallow any error
-          .catch(() => {})
-          .then(() => checkBrowsers(dir, false))
-      );
-    } else {
-      return checkBrowsers(dir, false);
+  return shouldSetBrowsers(isInteractive).then(shouldSetBrowsers => {
+    if (!shouldSetBrowsers) {
+      return checkBrowsers(dir, isInteractive, false);
     }
+
+    return (
+      pkgUp(dir)
+        .then(filePath => {
+          if (filePath == null) {
+            return Promise.reject();
+          }
+          const pkg = JSON.parse(fs.readFileSync(filePath));
+          pkg['browserslist'] = defaultBrowsers;
+          fs.writeFileSync(filePath, JSON.stringify(pkg, null, 2) + os.EOL);
+
+          browserslist.clearCaches();
+          console.log();
+          console.log(
+            `${chalk.green('Set target browsers:')} ${chalk.cyan(
+              defaultBrowsers.join(', ')
+            )}`
+          );
+          console.log();
+        })
+        // Swallow any error
+        .catch(() => {})
+        .then(() => checkBrowsers(dir, isInteractive, false))
+    );
   });
 }
 

packages/react-scripts/scripts/build.js

@@ -51,6 +51,8 @@ const useYarn = fs.existsSync(paths.yarnLockFile);
 const WARN_AFTER_BUNDLE_GZIP_SIZE = 512 * 1024;
 const WARN_AFTER_CHUNK_GZIP_SIZE = 1024 * 1024;
 
+const isInteractive = process.stdout.isTTY;
+
 // Warn and crash if required files are missing
 if (!checkRequiredFiles([paths.appHtml, paths.appIndexJs])) {
   process.exit(1);
@@ -63,7 +65,7 @@ const writeStatsJson = argv.indexOf('--stats') !== -1;
 // We require that you explictly set browsers and do not fall back to
 // browserslist defaults.
 const { checkBrowsers } = require('react-dev-utils/browsersHelper');
-checkBrowsers(paths.appPath)
+checkBrowsers(paths.appPath, isInteractive)
   .then(() => {
     // First, read the current file sizes in build directory.
     // This lets us display how much they changed later.

packages/react-scripts/scripts/start.js

@@ -78,7 +78,7 @@ if (process.env.HOST) {
 // We require that you explictly set browsers and do not fall back to
 // browserslist defaults.
 const { checkBrowsers } = require('react-dev-utils/browsersHelper');
-checkBrowsers(paths.appPath)
+checkBrowsers(paths.appPath, isInteractive)
   .then(() => {
     // We attempt to use the default port but if it is busy, we offer the user to
     // run on a different port. `choosePort()` Promise resolves to the next free port.