[PM-13274] [Unified] Add integration tests for creating and updating collections

[eliykat]

🎟️ Tracking

Main ticket: https://bitwarden.atlassian.net/browse/PM-21799

Relates to:

• Edit Collection/Save throws error. Includes changing names of collection and access permissions. #2788 tracked in https://bitwarden.atlassian.net/browse/PM-1383
• Adding a group to a collection fails #4865 tracked in https://bitwarden.atlassian.net/browse/PM-13274
• Broken feature after update 2023.5.0 - Unable to add user access permissions on Organization Collections #5815 tracked in https://bitwarden.atlassian.net/browse/PM-5074

📔 Objective

I was unable to reproduce the linked issues, however I took the opportunity to add db integration tests (which run on all our db providers) to confirm this. No other changes at this stage.

Vault changes are just moving the CollectionRepositoryTests into AC Team ownership.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.78%. Comparing base (1ec06fa) to head (4f88257).
Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5814      +/-   ##
==========================================
+ Coverage   47.54%   50.78%   +3.24%     
==========================================
  Files        1651     1651              
  Lines       74814    74814              
  Branches     6724     6724              
==========================================
+ Hits        35569    37994    +2425     
+ Misses      37787    35301    -2486     
- Partials     1458     1519      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checkmarx One – Scan Summary & Details – 48ce8296-8c4f-4e24-8146-7b9698559212

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	CSRF	/src/Billing/Controllers/PayPalController.cs: 70	details Method PostIpn at line 70 of /src/Billing/Controllers/PayPalController.cs gets a parameter from a user request from Body. This parameter value fl... ID: HIRv8XJ2uwImOjFqQXDx3QjwhSo%3D Attack Vector

Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	CSRF	/src/Api/Tools/Controllers/SendsController.cs: 196
	CSRF	/src/Billing/Controllers/FreshdeskController.cs: 43

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud