BRE-609/workflow-changes

[aj-bw]

🎟️ Tracking

BRE-609

📔 Objective

update workflows to be compliant with pull_request_target workflow linter rule ahead of changing rule log level to error

!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. -->

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – a14d8362-ab2a-4966-bca5-ec414d4ebbf4

New Issues (2)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	CSRF	/src/Billing/Controllers/PayPalController.cs: 70	details Method PostIpn at line 70 of /src/Billing/Controllers/PayPalController.cs gets a parameter from a user request from Body. This parameter value fl... ID: rowCJlRmaN1dTZe8leQMU7N1m8U%3D Attack Vector
	Missing_CSP_Header	/src/Core/MailTemplates/Handlebars/Billing/TrialInitiationVerifyEmail.html.hbs: 5	details A Content Security Policy is not explicitly defined within the web-application. ID: QypzWUzCL2qiFG6v23B59ISeF4g%3D Attack Vector

Fixed Issues (5)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	CSRF	/src/Api/Billing/Controllers/AccountsController.cs: 144
	CSRF	/src/Api/AdminConsole/Controllers/PoliciesController.cs: 69
	CSRF	/src/Api/AdminConsole/Public/Controllers/MembersController.cs: 95
	CSRF	/src/Api/AdminConsole/Controllers/PoliciesController.cs: 90
	CSRF	/src/Api/Vault/Controllers/SyncController.cs: 76

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.28%. Comparing base (d58836b) to head (5b77186).
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5783      +/-   ##
==========================================
- Coverage   50.47%   47.28%   -3.19%     
==========================================
  Files        1645     1645              
  Lines       74693    74693              
  Branches     6723     6723              
==========================================
- Hits        37698    35316    -2382     
- Misses      35476    37919    +2443     
+ Partials     1519     1458      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud