Skip to content

Commit 3f65041

Browse files
authored
Merge pull request #1 from bigcommerce/CATALOG-11541
chore: CATALOG-11541 Use catalog changes in fork repo
2 parents ca6cd22 + 1a0fb86 commit 3f65041

File tree

3 files changed

+40
-14
lines changed

3 files changed

+40
-14
lines changed

composer.json

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@
1515
"php-amqplib/php-amqplib": "^v3.6"
1616
},
1717
"require-dev": {
18-
"phpunit/phpunit": "^10.0|^11.0",
18+
"phpunit/phpunit": "^11.0",
1919
"mockery/mockery": "^1.0",
2020
"laravel/horizon": "^5.0",
2121
"orchestra/testbench": "^7.0|^8.0|^9.0|^10.0",
2222
"laravel/pint": "^1.2",
23-
"laravel/framework": "^9.0|^10.0|^11.0|^12.0"
23+
"laravel/framework": "^11.0|^12.0"
2424
},
2525
"autoload": {
2626
"psr-4": {
@@ -33,9 +33,6 @@
3333
}
3434
},
3535
"extra": {
36-
"branch-alias": {
37-
"dev-master": "13.0-dev"
38-
},
3936
"laravel": {
4037
"providers": [
4138
"VladimirYuldashev\\LaravelQueueRabbitMQ\\LaravelQueueRabbitMQServiceProvider"

src/Queue/Connection/ConfigFactory.php

Lines changed: 33 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,21 @@ public static function make(array $config = []): AMQPConnectionConfig
1818
{
1919
return tap(new AMQPConnectionConfig, function (AMQPConnectionConfig $connectionConfig) use ($config) {
2020
// Set the connection to a Lazy by default
21-
$connectionConfig->setIsLazy(! in_array(
22-
Arr::get($config, 'lazy') ?? true,
23-
[false, 0, '0', 'false', 'no'],
24-
true)
21+
$connectionConfig->setIsLazy(
22+
! in_array(
23+
Arr::get($config, 'lazy') ?? true,
24+
[false, 0, '0', 'false', 'no'],
25+
true
26+
)
2527
);
2628

2729
// Set the connection to unsecure by default
28-
$connectionConfig->setIsSecure(in_array(
29-
Arr::get($config, 'secure'),
30-
[true, 1, '1', 'true', 'yes'],
31-
true)
30+
$connectionConfig->setIsSecure(
31+
in_array(
32+
Arr::get($config, 'secure'),
33+
[true, 1, '1', 'true', 'yes'],
34+
true
35+
)
3236
);
3337

3438
if ($connectionConfig->isSecure()) {
@@ -38,6 +42,7 @@ public static function make(array $config = []): AMQPConnectionConfig
3842
self::getHostFromConfig($connectionConfig, $config);
3943
self::getHeartbeatFromConfig($connectionConfig, $config);
4044
self::getNetworkProtocolFromConfig($connectionConfig, $config);
45+
self::getReadWriteTimeoutFromConfig($connectionConfig, $config);
4146
});
4247
}
4348

@@ -99,4 +104,24 @@ protected static function getNetworkProtocolFromConfig(AMQPConnectionConfig $con
99104
$connectionConfig->setNetworkProtocol($networkProtocol);
100105
}
101106
}
107+
108+
protected static function getReadWriteTimeoutFromConfig(AMQPConnectionConfig $connectionConfig, array $config): void
109+
{
110+
$readTimeout = Arr::get($config, self::CONFIG_OPTIONS.'.read_timeout');
111+
$writeTimeout = Arr::get($config, self::CONFIG_OPTIONS.'.write_timeout');
112+
113+
if (is_numeric($readTimeout)) {
114+
$timeoutValue = (int) $readTimeout;
115+
if ($timeoutValue > 0) {
116+
$connectionConfig->setReadTimeout($timeoutValue);
117+
}
118+
}
119+
120+
if (is_numeric($writeTimeout)) {
121+
$timeoutValue = (int) $writeTimeout;
122+
if ($timeoutValue > 0) {
123+
$connectionConfig->setWriteTimeout($timeoutValue);
124+
}
125+
}
126+
}
102127
}

tests/Feature/ConnectorTest.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,8 @@ public function test_no_verification_ssl_connection(): void
168168
'verify_peer' => false,
169169
'passphrase' => null,
170170
],
171+
'read_timeout' => 10,
172+
'write_timeout' => 15,
171173
],
172174

173175
'worker' => env('RABBITMQ_WORKER', 'default'),
@@ -180,8 +182,10 @@ public function test_no_verification_ssl_connection(): void
180182
$connection = $queue->connection('rabbitmq');
181183
$this->assertInstanceOf(RabbitMQQueue::class, $connection);
182184
$this->assertInstanceOf(AMQPSSLConnection::class, $connection->getConnection());
183-
/** @var AMQPConnectionConfig */
185+
/** @var AMQPConnectionConfig $config */
184186
$config = $connection->getConnection()->getConfig();
185187
$this->assertFalse($config->getSslVerify());
188+
$this->assertEquals(10, $config->getReadTimeout());
189+
$this->assertEquals(15, $config->getWriteTimeout());
186190
}
187191
}

0 commit comments

Comments
 (0)