Skip to content

Commit 5620e46

Browse files
committed
install laravel pint, small improvements
1 parent 842ce70 commit 5620e46

File tree

7 files changed

+8
-68
lines changed

7 files changed

+8
-68
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,8 @@ jobs:
4242
- name: Install dependencies
4343
run: composer update --${{ matrix.stability }} --prefer-dist --no-interaction --no-progress
4444

45-
- name: Run PHP CS Fixer
46-
if: ${{ matrix.php != 8.0 }}
47-
run: vendor/bin/php-cs-fixer fix --config=.php-cs-fixer.dist.php --allow-risky=yes --dry-run --diff --verbose
45+
- name: Run Laravel Pint
46+
run: ./vendor/bin/pint --test
4847

4948
- name: Execute tests
5049
run: sleep 10 && vendor/bin/phpunit --verbose

.php-cs-fixer.dist.php

Lines changed: 0 additions & 57 deletions
This file was deleted.

.styleci.yml

Lines changed: 0 additions & 2 deletions
This file was deleted.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ Add connection to `config/queue.php`:
6363
* Set to "horizon" if you wish to use Laravel Horizon.
6464
*/
6565
'worker' => env('RABBITMQ_WORKER', 'default'),
66-
66+
'after_commit' => false,
6767
],
6868

6969
// ...

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
"phpunit/phpunit": "^9.3",
1919
"mockery/mockery": "^1.0",
2020
"laravel/horizon": "^5.0",
21-
"friendsofphp/php-cs-fixer": "^3.6",
22-
"orchestra/testbench": "^7.0"
21+
"orchestra/testbench": "^7.0",
22+
"laravel/pint": "^1.2"
2323
},
2424
"autoload": {
2525
"psr-4": {

src/Queue/Connectors/RabbitMQConnector.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public function connect(array $config): Queue
4444
Arr::get($config, 'worker', 'default'),
4545
$connection,
4646
$config['queue'],
47-
$config['after_commit'] ?? null,
47+
Arr::get($config, 'after_commit', false),
4848
Arr::get($config, 'options.queue', [])
4949
);
5050

@@ -97,7 +97,7 @@ protected function createQueue(
9797
string $worker,
9898
AbstractConnection $connection,
9999
string $queue,
100-
$dispatchAfterCommit,
100+
bool $dispatchAfterCommit,
101101
array $options = []
102102
) {
103103
switch ($worker) {

src/Queue/RabbitMQQueue.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ class RabbitMQQueue extends Queue implements QueueContract
9090
public function __construct(
9191
AbstractConnection $connection,
9292
string $default,
93-
$dispatchAfterCommit = false,
93+
bool $dispatchAfterCommit = false,
9494
array $options = []
9595
) {
9696
$this->connection = $connection;

0 commit comments

Comments
 (0)