Minor improvements and code style checks

Author: GoodforGod

src/main/java/io/api/etherscan/core/impl/EtherScanApi.java

@@ -65,7 +65,7 @@ public EtherScanApi(final String apiKey,
             throw new ApiException("Ethereum Network is set to NULL value");
 
         // EtherScan 5request\sec limit support by queue manager
-        final IQueueManager masterQueue = (apiKey.equals("YourApiKeyToken"))
+        final IQueueManager masterQueue = "YourApiKeyToken".equals(apiKey)
                 ? new FakeQueueManager()
                 : new QueueManager(5, 1);
 

src/main/java/io/api/etherscan/error/ConnectionException.java

@@ -1,8 +1,6 @@
 package io.api.etherscan.error;
 
 /**
- * ! NO DESCRIPTION !
- *
  * @author GoodforGod
  * @since 29.10.2018
  */

src/main/java/io/api/etherscan/executor/impl/HttpExecutor.java

@@ -96,7 +96,7 @@ public String get(final String urlAsString) {
         } catch (SocketTimeoutException e) {
             throw new ApiTimeoutException("Timeout: Could not establish connection for " + connectTimeout + " millis", e);
         } catch (Exception e) {
-            throw new ConnectionException(e.getLocalizedMessage(), e);
+            throw new ConnectionException(e.getMessage(), e);
         }
     }
 
@@ -126,7 +126,7 @@ public String post(final String urlAsString, final String dataToPost) {
         } catch (SocketTimeoutException e) {
             throw new ApiTimeoutException("Timeout: Could not establish connection for " + connectTimeout + " millis", e);
         } catch (Exception e) {
-            throw new ConnectionException(e.getLocalizedMessage(), e);
+            throw new ConnectionException(e.getMessage(), e);
         }
     }
 
@@ -136,8 +136,6 @@ private String readData(final HttpURLConnection connection) throws IOException {
             String inputLine;
             while ((inputLine = in.readLine()) != null)
                 content.append(inputLine);
-
-            in.close();
         }
 
         return content.toString();
@@ -146,11 +144,11 @@ private String readData(final HttpURLConnection connection) throws IOException {
     private InputStreamReader getStreamReader(final HttpURLConnection connection) throws IOException {
         switch (String.valueOf(connection.getContentEncoding())) {
             case "gzip":
-                return new InputStreamReader(new GZIPInputStream(connection.getInputStream()), "utf-8");
+                return new InputStreamReader(new GZIPInputStream(connection.getInputStream()), StandardCharsets.UTF_8);
             case "deflate":
-                return new InputStreamReader(new InflaterInputStream(connection.getInputStream()), "utf-8");
+                return new InputStreamReader(new InflaterInputStream(connection.getInputStream()), StandardCharsets.UTF_8);
             default:
-                return new InputStreamReader(connection.getInputStream(), "utf-8");
+                return new InputStreamReader(connection.getInputStream(), StandardCharsets.UTF_8);
         }
     }
 }

src/test/java/io/api/etherscan/account/AccountBalanceListTest.java

@@ -7,6 +7,7 @@
 import org.junit.Assert;
 import org.junit.Test;
 
+import java.math.BigInteger;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -18,7 +19,7 @@
  */
 public class AccountBalanceListTest extends Assert {
 
-    private EtherScanApi api = new EtherScanApi();
+    private final EtherScanApi api = new EtherScanApi();
 
     @Test
     public void correct() {
@@ -40,7 +41,7 @@ public void correct() {
             assertNotNull(balance.getEther());
             assertNotNull(balance.getGwei());
             assertNotNull(balance.getAddress());
-            assertNotEquals(0, balance.getWei());
+            assertNotEquals(BigInteger.ZERO, balance.getWei());
             assertNotNull(balance.toString());
         }
     }

src/test/java/io/api/etherscan/account/AccountBalanceTest.java

@@ -10,6 +10,7 @@
 import org.junit.runners.Parameterized;
 import org.junit.runners.Parameterized.Parameters;
 
+import java.math.BigInteger;
 import java.util.Arrays;
 import java.util.Collection;
 
@@ -74,7 +75,7 @@ public void correct() {
         assertNotNull(balance.getGwei());
         assertNotNull(balance.getEther());
         assertNotNull(balance.getAddress());
-        assertNotEquals(0, balance.getWei());
+        assertNotEquals(BigInteger.ZERO, balance.getWei());
         assertNotNull(balance.toString());
     }