Prepare for frozen string literals

- Add the magic comment to all files
- Update Overcommit::HookContext::PreCommit to not use encode!
- Set Rubocop target Ruby version to 2.3

Author: HarlemSquirrel

.rubocop.yml

@@ -1,5 +1,5 @@
 AllCops:
-  TargetRubyVersion: 2.2
+  TargetRubyVersion: 2.3
 
 Layout/ClosingParenthesisIndentation:
   Enabled: false

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec

bin/overcommit

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 # Check if Overcommit should invoke a Bundler context for loading gems
 require 'yaml'

lib/overcommit.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/os'
 require 'overcommit/constants'
 require 'overcommit/exceptions'

lib/overcommit/command_splitter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit
   # Distributes a list of arguments over multiple invocations of a command.
   #

lib/overcommit/configuration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'digest'
 require 'json'
 

lib/overcommit/configuration_validator.rb

@@ -1,4 +1,6 @@
-# rubocop:disable Metrics/ClassLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/MethodLength, Metrics/LineLength
+# frozen_string_literal: true
+
+# rubocop:disable Metrics/ClassLength, Metrics/MethodLength, Metrics/LineLength
 module Overcommit
   # Validates and normalizes a configuration.
   class ConfigurationValidator
@@ -82,8 +84,8 @@ def check_hook_env(hash)
       end
 
       if errors.any?
-        @log.error errors.join("\n") if @log
-        @log.newline if @log
+        @log&.error errors.join("\n")
+        @log&.newline
         raise Overcommit::Exceptions::ConfigurationError,
               'One or more hooks had an invalid `env` configuration option'
       end
@@ -107,8 +109,8 @@ def check_hook_name_format(hash)
       end
 
       if errors.any?
-        @log.error errors.join("\n") if @log
-        @log.newline if @log
+        @log&.error errors.join("\n")
+        @log&.newline
         raise Overcommit::Exceptions::ConfigurationError,
               'One or more hooks had invalid names'
       end
@@ -154,8 +156,8 @@ def check_for_too_many_processors(config, hash)
       end
 
       if errors.any?
-        @log.error errors.join("\n") if @log
-        @log.newline if @log
+        @log&.error errors.join("\n")
+        @log&.newline
         raise Overcommit::Exceptions::ConfigurationError,
               'One or more hooks had invalid `processor` value configured'
       end

lib/overcommit/constants.rb

@@ -3,10 +3,10 @@
 # Global application constants.
 module Overcommit
   HOME = File.expand_path(File.join(File.dirname(__FILE__), '..', '..')).freeze
-  CONFIG_FILE_NAME = '.overcommit.yml'.freeze
+  CONFIG_FILE_NAME = '.overcommit.yml'
 
   HOOK_DIRECTORY = File.join(HOME, 'lib', 'overcommit', 'hook').freeze
 
-  REPO_URL = 'https://github.com/brigade/overcommit'.freeze
-  BUG_REPORT_URL = "#{REPO_URL}/issues".freeze
+  REPO_URL = 'https://github.com/brigade/overcommit'
+  BUG_REPORT_URL = "#{REPO_URL}/issues"
 end

lib/overcommit/exceptions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Exceptions
   # Raised when a {Configuration} could not be loaded from a file.
   class ConfigurationError < StandardError; end

lib/overcommit/git_config.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/utils'
 
 module Overcommit

lib/overcommit/git_repo.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'iniparse'
 
 module Overcommit

lib/overcommit/git_version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Returns the version of the available git binary.
 #
 # This is intended to be used to conveniently execute code based on a specific

lib/overcommit/hook/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'forwardable'
 require 'overcommit/message_processor'
 

lib/overcommit/hook/commit_msg/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'forwardable'
 
 module Overcommit::Hook::CommitMsg

lib/overcommit/hook/commit_msg/capitalized_subject.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Ensures commit message subject lines start with a capital letter.
   class CapitalizedSubject < Base

lib/overcommit/hook/commit_msg/empty_message.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Checks that the commit message is not empty
   class EmptyMessage < Base

lib/overcommit/hook/commit_msg/gerrit_change_id.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Ensures a Gerrit Change-Id line is included in the commit message.
   #

lib/overcommit/hook/commit_msg/hard_tabs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Checks for hard tabs in commit messages.
   class HardTabs < Base

lib/overcommit/hook/commit_msg/message_format.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Ensures the commit message follows a specific format.
   class MessageFormat < Base

lib/overcommit/hook/commit_msg/russian_novel.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Checks for long commit messages (not good or bad--just fun to point out)
   class RussianNovel < Base

lib/overcommit/hook/commit_msg/single_line_subject.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Ensures commit message subject lines are followed by a blank line.
   class SingleLineSubject < Base

lib/overcommit/hook/commit_msg/spell_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'tempfile'
 
 module Overcommit::Hook::CommitMsg

lib/overcommit/hook/commit_msg/text_width.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Ensures the number of columns the subject and commit message lines occupy is
   # under the preferred limits.

lib/overcommit/hook/commit_msg/trailing_period.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Ensures commit message subject lines do not have a trailing period
   class TrailingPeriod < Base

lib/overcommit/hook/post_checkout/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'forwardable'
 
 module Overcommit::Hook::PostCheckout

lib/overcommit/hook/post_checkout/bower_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/bower_install'
 
 module Overcommit::Hook::PostCheckout

lib/overcommit/hook/post_checkout/bundle_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/bundle_install'
 
 module Overcommit::Hook::PostCheckout

lib/overcommit/hook/post_checkout/composer_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/composer_install'
 
 module Overcommit::Hook::PostCheckout

lib/overcommit/hook/post_checkout/index_tags.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/index_tags'
 
 module Overcommit::Hook::PostCheckout

lib/overcommit/hook/post_checkout/npm_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/npm_install'
 
 module Overcommit::Hook::PostCheckout

lib/overcommit/hook/post_checkout/submodule_status.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/submodule_status'
 
 module Overcommit::Hook::PostCheckout

lib/overcommit/hook/post_checkout/yarn_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/yarn_install'
 
 module Overcommit::Hook::PostCheckout

lib/overcommit/hook/post_commit/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'forwardable'
 
 module Overcommit::Hook::PostCommit

lib/overcommit/hook/post_commit/bower_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/bower_install'
 
 module Overcommit::Hook::PostCommit

lib/overcommit/hook/post_commit/bundle_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/bundle_install'
 
 module Overcommit::Hook::PostCommit

lib/overcommit/hook/post_commit/commitplease.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PostCommit
   # Check that a commit message conforms to a certain style
   #

lib/overcommit/hook/post_commit/composer_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/composer_install'
 
 module Overcommit::Hook::PostCommit

lib/overcommit/hook/post_commit/git_guilt.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PostCommit
   # Calculates the change in blame since the last revision.
   #

lib/overcommit/hook/post_commit/index_tags.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/index_tags'
 
 module Overcommit::Hook::PostCommit

lib/overcommit/hook/post_commit/npm_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/npm_install'
 
 module Overcommit::Hook::PostCommit

lib/overcommit/hook/post_commit/submodule_status.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/submodule_status'
 
 module Overcommit::Hook::PostCommit

lib/overcommit/hook/post_commit/yarn_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/yarn_install'
 
 module Overcommit::Hook::PostCommit

lib/overcommit/hook/post_merge/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'forwardable'
 
 module Overcommit::Hook::PostMerge

lib/overcommit/hook/post_merge/bower_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/bower_install'
 
 module Overcommit::Hook::PostMerge

lib/overcommit/hook/post_merge/bundle_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/bundle_install'
 
 module Overcommit::Hook::PostMerge

lib/overcommit/hook/post_merge/composer_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/composer_install'
 
 module Overcommit::Hook::PostMerge

lib/overcommit/hook/post_merge/index_tags.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/index_tags'
 
 module Overcommit::Hook::PostMerge

lib/overcommit/hook/post_merge/npm_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/npm_install'
 
 module Overcommit::Hook::PostMerge

lib/overcommit/hook/post_merge/submodule_status.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/submodule_status'
 
 module Overcommit::Hook::PostMerge

lib/overcommit/hook/post_merge/yarn_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/yarn_install'
 
 module Overcommit::Hook::PostMerge

lib/overcommit/hook/post_rewrite/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'forwardable'
 
 module Overcommit::Hook::PostRewrite

lib/overcommit/hook/post_rewrite/bower_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/bower_install'
 
 module Overcommit::Hook::PostRewrite

lib/overcommit/hook/post_rewrite/bundle_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/bundle_install'
 
 module Overcommit::Hook::PostRewrite

lib/overcommit/hook/post_rewrite/composer_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/composer_install'
 
 module Overcommit::Hook::PostRewrite

lib/overcommit/hook/post_rewrite/index_tags.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/index_tags'
 
 module Overcommit::Hook::PostRewrite

lib/overcommit/hook/post_rewrite/npm_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/npm_install'
 
 module Overcommit::Hook::PostRewrite

lib/overcommit/hook/post_rewrite/submodule_status.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/submodule_status'
 
 module Overcommit::Hook::PostRewrite

lib/overcommit/hook/post_rewrite/yarn_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/yarn_install'
 
 module Overcommit::Hook::PostRewrite

lib/overcommit/hook/pre_commit/author_email.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Checks the format of an author's email address.
   class AuthorEmail < Base