Skip to content

Commit a4681bd

Browse files
committed
Pass TrailingPeriod hook when commit message is empty
1 parent 852d1e8 commit a4681bd

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

lib/overcommit/hook/commit_msg/trailing_period.rb

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ module Overcommit::Hook::CommitMsg
22
# Ensures commit message subject lines do not have a trailing period
33
class TrailingPeriod < Base
44
def run
5+
return :pass if empty_message?
6+
57
if commit_message_lines.first.rstrip.end_with?('.')
68
return :warn, 'Please omit trailing period from commit message subject'
79
end

spec/overcommit/hook/commit_msg/trailing_period_spec.rb

+7
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,13 @@
77

88
before do
99
subject.stub(:commit_message_lines).and_return(commit_msg.split("\n"))
10+
subject.stub(:empty_message?).and_return(commit_msg.empty?)
11+
end
12+
13+
context 'when commit message is empty' do
14+
let(:commit_msg) { '' }
15+
16+
it { should pass }
1017
end
1118

1219
context 'when subject contains a trailing period' do

0 commit comments

Comments
 (0)