[STORE] Added integration tests for the Repository pattern

Related: elastic#71

Author: karmi

elasticsearch-persistence/elasticsearch-persistence.gemspec

@@ -29,8 +29,10 @@ Gem::Specification.new do |s|
   s.add_development_dependency "bundler", "~> 1.5"
   s.add_development_dependency "rake"
 
-  s.add_development_dependency "elasticsearch-extensions"
   s.add_development_dependency "oj"
+  s.add_development_dependency "virtus"
+
+  s.add_development_dependency "elasticsearch-extensions"
 
   s.add_development_dependency "shoulda-context"
   s.add_development_dependency "mocha"

elasticsearch-persistence/test/integration/repository/custom_class_test.rb

@@ -0,0 +1,85 @@
+require 'test_helper'
+
+module Elasticsearch
+  module Persistence
+    class RepositoryCustomClassIntegrationTest < Elasticsearch::Test::IntegrationTestCase
+
+      class ::MyNote
+        attr_reader :attributes
+
+        def initialize(attributes={})
+          @attributes = Hashie::Mash.new(attributes)
+        end
+
+        def method_missing(method_name, *arguments, &block)
+          attributes.respond_to?(method_name) ? attributes.__send__(method_name, *arguments, &block) : super
+        end
+
+        def respond_to?(method_name, include_private=false)
+          attributes.respond_to?(method_name) || super
+        end
+
+        def to_hash
+          @attributes
+        end
+      end
+
+      context "A custom repository class" do
+        setup do
+          class ::MyNotesRepository
+            include Elasticsearch::Persistence::Repository
+
+            klass MyNote
+
+            settings number_of_shards: 1 do
+              mapping do
+                indexes :title, analyzer: 'snowball'
+              end
+            end
+
+            create_index!
+
+            def deserialize(document)
+              klass.new document.merge(document['_source'])
+            end
+          end
+
+          @repository = MyNotesRepository.new
+
+          @repository.client.cluster.health wait_for_status: 'yellow'
+        end
+
+        should "save the object under a correct index and type" do
+          @repository.save MyNote.new(id: '1', title: 'Test')
+          result = @repository.find(1)
+
+          assert_instance_of MyNote, result
+          assert_equal 'Test', result.title
+
+          assert_not_nil Elasticsearch::Persistence.client.get index: 'my_notes_repository',
+                                                               type: 'my_note',
+                                                               id: '1'
+        end
+
+        should "delete the object" do
+          note = MyNote.new id: 1, title: 'Test'
+          @repository.save note
+
+          assert_not_nil @repository.find(1)
+
+          @repository.delete(note)
+          assert_raise(Elasticsearch::Persistence::Repository::DocumentNotFound) { @repository.find(1) }
+        end
+
+        should "retrieve the object via a search query" do
+          note = MyNote.new title: 'Testing'
+          @repository.save note, refresh: true
+
+          results = @repository.search query: { match: { title: 'Test' } }
+          assert_equal 'Testing', results.first.title
+        end
+      end
+
+    end
+  end
+end

elasticsearch-persistence/test/integration/repository/customized_class_test.rb

@@ -0,0 +1,68 @@
+require 'test_helper'
+
+module Elasticsearch
+  module Persistence
+    class RepositoryCustomizedClassIntegrationTest < Elasticsearch::Test::IntegrationTestCase
+
+      module ::My
+        class Note
+          attr_reader :attributes
+
+          def initialize(attributes={})
+            @attributes = attributes
+          end
+
+          def to_hash
+            @attributes
+          end
+        end
+      end
+
+      context "A custom repository class" do
+        setup do
+          @repository = Elasticsearch::Persistence::Repository.new do
+            index 'my_notes'
+            type  'my_note'
+            klass My::Note
+
+            settings number_of_shards: 1 do
+              mapping do
+                indexes :title, analyzer: 'snowball'
+              end
+            end
+
+            create_index!
+          end
+
+          @repository.client.cluster.health wait_for_status: 'yellow'
+        end
+
+        should "save the object under a correct index and type" do
+          @repository.save My::Note.new(id: '1', title: 'Test')
+
+          assert_instance_of My::Note, @repository.find(1)
+          assert_not_nil Elasticsearch::Persistence.client.get index: 'my_notes', type: 'my_note', id: '1'
+        end
+
+        should "delete the object" do
+          note = My::Note.new id: 1, title: 'Test'
+          @repository.save note
+
+          assert_not_nil @repository.find(1)
+
+          @repository.delete(note)
+          assert_raise(Elasticsearch::Persistence::Repository::DocumentNotFound) { @repository.find(1) }
+        end
+
+        should "create the index with correct mapping" do
+          note = My::Note.new title: 'Testing'
+          @repository.save note, refresh: true
+
+          results = @repository.search query: { match: { title: 'Test' } }
+          assert_equal 'Testing', results.first.attributes['title']
+        end
+      end
+
+    end
+  end
+end

elasticsearch-persistence/test/integration/repository/default_class_test.rb

@@ -0,0 +1,89 @@
+require 'test_helper'
+
+module Elasticsearch
+  module Persistence
+    class RepositoryDefaultClassIntegrationTest < Elasticsearch::Test::IntegrationTestCase
+
+      class ::Note
+        attr_reader :attributes
+
+        def initialize(attributes={})
+          @attributes = attributes
+        end
+
+        def to_hash
+          @attributes
+        end
+      end
+
+      context "The default repository class" do
+        setup do
+          @repository = Elasticsearch::Persistence::Repository.new
+          @repository.client.cluster.health wait_for_status: 'yellow'
+        end
+
+        should "save the object with a custom ID and find it" do
+          @repository.save Note.new(id: '1', title: 'Test')
+
+          assert_equal 'Test', @repository.find(1).attributes['title']
+        end
+
+        should "save the object with an auto-generated ID and find it" do
+          response = @repository.save Note.new(title: 'Test')
+
+          assert_equal 'Test', @repository.find(response['_id']).attributes['title']
+        end
+
+        should "delete an object" do
+          note = Note.new(id: '1', title: 'Test')
+
+          @repository.save(note)
+          assert_not_nil @repository.find(1)
+          @repository.delete(note)
+          assert_raise(Elasticsearch::Persistence::Repository::DocumentNotFound) { @repository.find(1) }
+        end
+
+        should "find multiple objects" do
+          (1..5).each { |i| @repository.save Note.new(id: i, title: "Test #{i}") }
+
+          assert_equal 5, @repository.find(1, 2, 3, 4, 5).size
+          assert_equal 5, @repository.find([1, 2, 3, 4, 5]).size
+        end
+
+        should "pass options to save and find" do
+          note = Note.new(id: '1', title: 'Test')
+          @repository.save note, routing: 'ABC'
+
+          assert_raise Elasticsearch::Persistence::Repository::DocumentNotFound do
+            @repository.find(1, routing: 'DEF')
+          end
+
+          assert_nothing_raised do
+            note = @repository.find(1, routing: 'ABC')
+            assert_instance_of Note, note
+          end
+        end
+
+        should "find notes with full text search" do
+          @repository.save Note.new(title: 'Test')
+          @repository.save Note.new(title: 'Test Test')
+          @repository.save Note.new(title: 'Crust')
+          @repository.client.indices.refresh index: @repository.index_name
+
+          results = @repository.search 'test'
+          assert_equal 2, results.size
+
+          results = @repository.search query: { match: { title: 'Test' } }
+          assert_equal 2, results.size
+        end
+
+        should "save and find a plain hash" do
+          @repository.save id: 1, title: 'Hash'
+          result = @repository.find(1)
+          assert_equal 'Hash', result['_source']['title']
+        end
+      end
+
+    end
+  end
+end

elasticsearch-persistence/test/integration/repository/virtus_model_test.rb

@@ -0,0 +1,45 @@
+require 'test_helper'
+
+require 'virtus'
+
+module Elasticsearch
+  module Persistence
+    class RepositoryWithVirtusIntegrationTest < Elasticsearch::Test::IntegrationTestCase
+
+      class ::Page
+        include Virtus.model
+
+        attribute :title,     String
+        attribute :views,     Integer, default: 0
+        attribute :published, Boolean, default: false
+        attribute :slug,      String,  default: lambda { |page, attribute| page.title.downcase.gsub(' ', '-') }
+      end
+
+      context "The repository with a Virtus model" do
+        setup do
+          @repository = Elasticsearch::Persistence::Repository.new do
+            index :pages
+          end
+        end
+
+        should "save and find the object" do
+          page = Page.new title: 'Test Page'
+
+          response = @repository.save page
+          id = response['_id']
+
+          result = @repository.find(id)
+
+          assert_instance_of Page,  result
+          assert_equal 'Test Page', result.title
+          assert_equal 0,           result.views
+
+          assert_not_nil Elasticsearch::Persistence.client.get index: 'pages',
+                                                               type: 'page',
+                                                               id: id
+        end
+      end
+
+    end
+  end
+end

elasticsearch-persistence/test/test_helper.rb

@@ -37,6 +37,10 @@ def setup
                                               host: "localhost:#{(ENV['TEST_CLUSTER_PORT'] || 9250)}",
                                               tracer: (ENV['QUIET'] ? nil : tracer)
       end
+
+      def teardown
+        Elasticsearch::Persistence.client.indices.delete index: '_all'
+      end
     end
   end
 end