Replace IdentitySet with HashSet<object> (nhibernate#2356)

Author: bahusoid

src/NHibernate.Test/UtilityTest/IdentitySetFixture.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections;
 using System.Collections.Generic;
-using System.Runtime.CompilerServices;
 using NHibernate.Util;
 using NUnit.Framework;
 
@@ -10,6 +9,8 @@ namespace NHibernate.Test.UtilityTest
 	/// <summary>
 	/// Test for the IdentityMap.
 	/// </summary>
+	// Since 5.3
+	[Obsolete("This class has no more usages and will be removed in a future version")]
 	[TestFixture]
 	public class IdentitySetFixture
 	{

src/NHibernate/Async/Engine/Query/HQLQueryPlan.cs

@@ -58,7 +58,7 @@ public async Task PerformListAsync(QueryParameters queryParameters, ISessionImpl
 			}
 
 			IList combinedResults = results ?? new List<object>();
-			IdentitySet distinction = new IdentitySet();
+			var distinction = new HashSet<object>(ReferenceComparer<object>.Instance);
 			int includedCount = -1;
 			for (int i = 0; i < Translators.Length; i++)
 			{

src/NHibernate/Async/Event/Default/DefaultDeleteEventListener.cs

@@ -37,7 +37,7 @@ public virtual Task OnDeleteAsync(DeleteEvent @event, CancellationToken cancella
 			{
 				return Task.FromCanceled<object>(cancellationToken);
 			}
-			return OnDeleteAsync(@event, new IdentitySet(), cancellationToken);
+			return OnDeleteAsync(@event, new HashSet<object>(ReferenceComparer<object>.Instance), cancellationToken);
 		}
 
 		public virtual async Task OnDeleteAsync(DeleteEvent @event, ISet<object> transientEntities, CancellationToken cancellationToken)
@@ -145,7 +145,7 @@ protected virtual async Task DeleteTransientEntityAsync(IEventSource session, ob
 			// NH different impl : NH-1895
 			if(transientEntities == null)
 			{
-				transientEntities = new HashSet<object>();
+				transientEntities = new HashSet<object>(ReferenceComparer<object>.Instance);
 			}
 			if (!transientEntities.Add(entity))
 			{

src/NHibernate/Async/Hql/Ast/ANTLR/QueryTranslatorImpl.cs

@@ -77,7 +77,7 @@ public async Task<IList> ListAsync(ISessionImplementor session, QueryParameters
 
 				int size = results.Count;
 				var tmp = new List<object>();
-				var distinction = new IdentitySet();
+				var distinction = new HashSet<object>(ReferenceComparer<object>.Instance);
 
 				for ( int i = 0; i < size; i++ ) 
 				{

src/NHibernate/Engine/Query/HQLQueryPlan.cs

@@ -108,7 +108,7 @@ public void PerformList(QueryParameters queryParameters, ISessionImplementor ses
 			}
 
 			IList combinedResults = results ?? new List<object>();
-			IdentitySet distinction = new IdentitySet();
+			var distinction = new HashSet<object>(ReferenceComparer<object>.Instance);
 			int includedCount = -1;
 			for (int i = 0; i < Translators.Length; i++)
 			{

src/NHibernate/Event/Default/DefaultDeleteEventListener.cs

@@ -26,7 +26,7 @@ public partial class DefaultDeleteEventListener : IDeleteEventListener
 		/// <param name="event">The delete event to be handled. </param>
 		public virtual void OnDelete(DeleteEvent @event)
 		{
-			OnDelete(@event, new IdentitySet());
+			OnDelete(@event, new HashSet<object>(ReferenceComparer<object>.Instance));
 		}
 
 		public virtual void OnDelete(DeleteEvent @event, ISet<object> transientEntities)
@@ -143,7 +143,7 @@ protected virtual void DeleteTransientEntity(IEventSource session, object entity
 			// NH different impl : NH-1895
 			if(transientEntities == null)
 			{
-				transientEntities = new HashSet<object>();
+				transientEntities = new HashSet<object>(ReferenceComparer<object>.Instance);
 			}
 			if (!transientEntities.Add(entity))
 			{

src/NHibernate/Hql/Ast/ANTLR/QueryTranslatorImpl.cs

@@ -123,7 +123,7 @@ public IList List(ISessionImplementor session, QueryParameters queryParameters)
 
 				int size = results.Count;
 				var tmp = new List<object>();
-				var distinction = new IdentitySet();
+				var distinction = new HashSet<object>(ReferenceComparer<object>.Instance);
 
 				for ( int i = 0; i < size; i++ ) 
 				{

src/NHibernate/Util/IdentitySet.cs

@@ -1,13 +1,14 @@
 using System;
 using System.Collections;
 using System.Collections.Generic;
-using System.Linq;
 
 namespace NHibernate.Util
 {
 	/// <summary> 
 	/// Set implementation that use reference equals instead of Equals() as its comparison mechanism.
 	/// </summary>
+	// Since 5.3
+	[Obsolete("This class has no more usages and will be removed in a future version")]
 	public class IdentitySet : ISet<object>
 	{
 		private IDictionary map;