NH-3988 - Replace ApplicationException with Exception

Author: hazzik

src/NHibernate.Test/NHSpecificTest/NH1985/SampleTest.cs

@@ -10,11 +10,9 @@ public class SampleTest : BugTestCase
 	{
 		protected override void OnSetUp()
 		{
-			base.OnSetUp();
-
 			if (0 == ExecuteStatement("INSERT INTO DomainClass (Id, Label) VALUES (1, 'TEST record');"))
 			{
-				throw new ApplicationException("Insertion of test record failed.");
+				Assert.Fail("Insertion of test record failed.");
 			}
 		}
 
@@ -26,7 +24,7 @@ protected override void OnTearDown()
 		}
 
 		[Test]
-		[Ignore("It is valid to be delete immutable entities")]
+		[Ignore("It is valid to delete immutable entities")]
 		public void AttemptToDeleteImmutableObjectShouldThrow()
 		{
 			using (ISession session = OpenSession())

src/NHibernate/AssertionFailure.cs

@@ -8,7 +8,7 @@ namespace NHibernate
 	/// Indicates failure of an assertion: a possible bug in NHibernate
 	/// </summary>
 	[Serializable]
-	public class AssertionFailure : ApplicationException
+	public class AssertionFailure : Exception
 	{
 		private const string DefaultMessage = "An AssertionFailure occurred - this may indicate a bug in NHibernate or in your custom types.";
 

src/NHibernate/HibernateException.cs

@@ -10,7 +10,7 @@ namespace NHibernate
 	/// Exceptions that occur in the database layer are left as native exceptions.
 	/// </remarks>
 	[Serializable]
-	public class HibernateException : ApplicationException
+	public class HibernateException : Exception
 	{
 		/// <summary>
 		/// Initializes a new instance of the <see cref="HibernateException"/> class.

src/NHibernate/Logging.cs

@@ -63,15 +63,15 @@ private static ILoggerFactory GetLoggerFactory(string nhibernateLoggerClass)
 			}
 			catch (MissingMethodException ex)
 			{
-				throw new ApplicationException("Public constructor was not found for " + loggerFactoryType, ex);
+				throw new InstantiationException("Public constructor was not found for " + loggerFactoryType, ex, loggerFactoryType);
 			}
 			catch (InvalidCastException ex)
 			{
-				throw new ApplicationException(loggerFactoryType + "Type does not implement " + typeof (ILoggerFactory), ex);
+				throw new InstantiationException(loggerFactoryType + "Type does not implement " + typeof (ILoggerFactory), ex, loggerFactoryType);
 			}
 			catch (Exception ex)
 			{
-				throw new ApplicationException("Unable to instantiate: " + loggerFactoryType, ex);
+				throw new InstantiationException("Unable to instantiate: " + loggerFactoryType, ex, loggerFactoryType);
 			}
 			return loggerFactory;
 		}

src/NHibernate/Util/TypeNameParser.cs

@@ -6,7 +6,7 @@
 
 namespace NHibernate.Util
 {
-	public class ParserException : ApplicationException
+	public class ParserException : Exception
 	{
 		public ParserException(string message) : base(message) { }
 	}