Refactor tests (#94)

* Refactor tests

* Refactor tests

* Refactor tests

* Refactor tests

Author: Kohei Asai

solutions/addBinary.test.ts

@@ -1,11 +1,14 @@
 import addBinary from "./addBinary";
 
 describe("67. Add Binary", () => {
-  test("#1", () => {
-    expect(addBinary("11", "1")).toBe("100");
-  });
+  const TEST_CASES = new Map([
+    [["11", "1"], "100"],
+    [["1010", "1011"], "10101"]
+  ]);
 
-  test("#2", () => {
-    expect(addBinary("1010", "1011")).toBe("10101");
-  });
+  for (const [[a, b], expected] of TEST_CASES) {
+    it(`returns ${expected} when called with ${a} and ${b}`, () => {
+      expect(addBinary(a, b)).toBe(expected);
+    });
+  }
 });

solutions/backspaceStringCompare.test.ts

@@ -1,19 +1,16 @@
 import backspaceCompare from "./backspaceStringCompare";
 
 describe("844. Backspace String Compare", () => {
-  test("#1", () => {
-    expect(backspaceCompare("ab#c", "ad#c")).toBe(true);
-  });
+  const TEST_CASES = new Map([
+    [["ab#c", "ad#c"], true],
+    [["ab##", "c#d#"], true],
+    [["a##c", "#a#c"], true],
+    [["a#c", "b"], false]
+  ]);
 
-  test("#2", () => {
-    expect(backspaceCompare("ab##", "c#d#")).toBe(true);
-  });
-
-  test("#3", () => {
-    expect(backspaceCompare("a##c", "#a#c")).toBe(true);
-  });
-
-  test("#4", () => {
-    expect(backspaceCompare("a#c", "b")).toBe(false);
-  });
+  for (const [[s, t], expected] of TEST_CASES) {
+    it(`returns ${expected} when called with ${s} and ${t}`, () => {
+      expect(backspaceCompare(s, t)).toBe(expected);
+    });
+  }
 });

solutions/bestTimeToBuyAndSellStock.test.ts

@@ -1,19 +1,16 @@
 import maxProfit from "./bestTimeToBuyAndSellStock";
 
 describe("121. Best Time to Buy and Sell Stock", () => {
-  test("#1", () => {
-    expect(maxProfit([7, 1, 5, 3, 6, 4])).toBe(5);
-  });
+  const TEST_CASES = new Map([
+    [[7, 1, 5, 3, 6, 4], 5],
+    [[7, 6, 4, 3, 1], 0],
+    [[7, 6, 5, 2, 3, 4, 1], 2],
+    [[7, 3, 8, 1, 2, 5, 4], 5]
+  ]);
 
-  test("#2", () => {
-    expect(maxProfit([7, 6, 4, 3, 1])).toBe(0);
-  });
-
-  test("#3", () => {
-    expect(maxProfit([7, 6, 5, 2, 3, 4, 1])).toBe(2);
-  });
-
-  test("#4", () => {
-    expect(maxProfit([7, 3, 8, 1, 2, 5, 4])).toBe(5);
-  });
+  for (const [prices, expected] of TEST_CASES) {
+    it(`returns ${expected} when called with [${prices}]`, () => {
+      expect(maxProfit(prices)).toBe(expected);
+    });
+  }
 });

solutions/binarySearch.test.ts

@@ -1,11 +1,14 @@
 import search from "./binarySearch";
 
 describe("704. Binary Search", () => {
-  test("#1", () => {
-    expect(search([-1, 0, 3, 5, 9, 12], 9)).toBe(4);
-  });
+  const TEST_CASES = new Map<[number[], number], number>([
+    [[[-1, 0, 3, 5, 9, 12], 9], 4],
+    [[[-1, 0, 3, 5, 9, 12], 13], -1]
+  ]);
 
-  test("#2", () => {
-    expect(search([-1, 0, 3, 5, 9, 12], 13)).toBe(-1);
-  });
+  for (const [[nums, target], expected] of TEST_CASES) {
+    it(`returns ${expected} when called with [${nums}] and ${target}`, () => {
+      expect(search(nums, target)).toBe(expected);
+    });
+  }
 });

solutions/binaryTreePreorderTraversal.test.ts

@@ -14,7 +14,7 @@ describe("144. Binary Tree Preorder Traversal", () => {
   ]);
 
   for (const [tree, expected] of TEST_CASES) {
-    test(`when [${tree.join(", ")}]`, () => {
+    it(`returns ${expected} when called with [${tree}]`, () => {
       expect(preorderTraversal(createBinaryTreeNode(tree))).toEqual(expected);
     });
   }

solutions/bullsAndCows.test.ts

@@ -1,31 +1,19 @@
 import getHint from "./bullsAndCows";
 
 describe("299. Bulls and Cows", () => {
-  test("#1", () => {
-    expect(getHint("1807", "7810")).toBe("1A3B");
-  });
+  const TEST_CASES = new Map([
+    [["1807", "7810"], "1A3B"],
+    [["1123", "0111"], "1A1B"],
+    [["1234", "5678"], "0A0B"],
+    [["1234", "1234"], "4A0B"],
+    [["1234", "4123"], "0A4B"],
+    [["1122", "0001"], "0A1B"],
+    [["11", "10"], "1A0B"]
+  ]);
 
-  test("#2", () => {
-    expect(getHint("1123", "0111")).toBe("1A1B");
-  });
-
-  test("#3", () => {
-    expect(getHint("1234", "5678")).toBe("0A0B");
-  });
-
-  test("#4", () => {
-    expect(getHint("1234", "1234")).toBe("4A0B");
-  });
-
-  test("#5", () => {
-    expect(getHint("1234", "4123")).toBe("0A4B");
-  });
-
-  test("#6", () => {
-    expect(getHint("1122", "0001")).toBe("0A1B");
-  });
-
-  test("#7", () => {
-    expect(getHint("11", "10")).toBe("1A0B");
-  });
+  for (const [[secret, guess], expected] of TEST_CASES) {
+    it(`returns ${expected} when called with ${secret} and ${guess}`, () => {
+      expect(getHint(secret, guess)).toBe(expected);
+    });
+  }
 });

solutions/climbingStairs.test.ts

@@ -1,23 +1,11 @@
 import climbStairs from "./climbingStairs";
 
 describe("70. Climbing Stairs", () => {
-  test("#1", () => {
-    expect(climbStairs(1)).toBe(1);
-  });
+  const TEST_CASES = new Map([[1, 1], [2, 2], [3, 3], [4, 5], [32, 3524578]]);
 
-  test("#2", () => {
-    expect(climbStairs(2)).toBe(2);
-  });
-
-  test("#3", () => {
-    expect(climbStairs(3)).toBe(3);
-  });
-
-  test("#4", () => {
-    expect(climbStairs(4)).toBe(5);
-  });
-
-  test("#5", () => {
-    expect(climbStairs(32)).toBe(3524578);
-  });
+  for (const [n, expected] of TEST_CASES) {
+    it(`returns ${expected} when called with ${n}`, () => {
+      expect(climbStairs(n)).toBe(expected);
+    });
+  }
 });

solutions/countAndSay.test.ts

@@ -1,33 +1,22 @@
 import countAndSay from "./countAndSay";
 
 describe("38. Count and Say", () => {
-  test("#1", () => {
-    expect(countAndSay(1)).toBe("1");
-  });
-
-  test("#2", () => {
-    expect(countAndSay(2)).toBe("11");
-  });
-
-  test("#3", () => {
-    expect(countAndSay(3)).toBe("21");
-  });
-
-  test("#4", () => {
-    expect(countAndSay(4)).toBe("1211");
-  });
-
-  test("#5", () => {
-    expect(countAndSay(5)).toBe("111221");
-  });
-
-  test("#6", () => {
-    expect(countAndSay(10)).toBe("13211311123113112211");
-  });
-
-  test("#7", () => {
-    expect(countAndSay(30)).toBe(
+  const TEST_CASES = new Map([
+    [1, "1"],
+    [2, "11"],
+    [3, "21"],
+    [4, "1211"],
+    [5, "111221"],
+    [10, "13211311123113112211"],
+    [
+      30,
       "3113112221131112311332111213122112311311123112111331121113122112132113121113222112311311221112131221123113112221121113311211131122211211131221131211132221121321132132212321121113121112133221123113112221131112212211131221121321131211132221123113112221131112311332211211133112111311222112111312211311123113322112111312211312111322212321121113121112133221121321132132211331121321132213211231132132211211131221232112111312212221121123222112311311222113111231133211121321321122111312211312111322211213211321322123211211131211121332211231131122211311123113321112131221123113111231121123222112111331121113112221121113122113111231133221121113122113121113221112131221123113111231121123222112111312211312111322212321121113121112131112132112311321322112111312212321121113122122211211232221121321132132211331121321231231121113112221121321132132211322132113213221123113112221133112132123222112111312211312112213211231132132211211131221131211322113321132211221121332211231131122211311123113321112131221123113111231121113311211131221121321131211132221123113112211121312211231131122211211133112111311222112111312211312111322211213211321223112111311222112132113213221133122211311221122111312211312111322212321121113121112131112132112311321322112111312212321121113122122211211232221121321132132211331121321231231121113112221121321132132211322132113213221123113112221133112132123222112111312211312112213211231132132211211131221131211322113321132211221121332211213211321322113311213212312311211131122211213211331121321123123211231131122211211131221131112311332211213211321223112111311222112132113213221123123211231132132211231131122211311123113322112111312211312111322111213122112311311123112112322211213211321322113312211223113112221121113122113111231133221121321132132211331222113321112131122211332113221122112133221123113112221131112311332111213122112311311123112111331121113122112132113121113222112311311221112131221123113112221121113311211131122211211131221131211132221121321132132212321121113121112133221123113112221131112311332111213122112311311123112112322211322311311222113111231133211121312211231131112311211232221121113122113121113222123211211131221132211131221121321131211132221123113112211121312211231131122113221122112133221121321132132211331121321231231121113121113122122311311222113111231133221121113122113121113221112131221123113111231121123222112132113213221133112132123123112111312211322311211133112111312211213211311123113223112111321322123122113222122211211232221121113122113121113222123211211131211121311121321123113213221121113122123211211131221121311121312211213211321322112311311222113311213212322211211131221131211221321123113213221121113122113121113222112131112131221121321131211132221121321132132211331121321232221123113112221131112311322311211131122211213211331121321122112133221121113122113121113222123112221221321132132211231131122211331121321232221121113122113121113222123211211131211121332211213111213122112132113121113222112132113213221232112111312111213322112132113213221133112132123123112111311222112132113311213211221121332211231131122211311123113321112131221123113112221132231131122211211131221131112311332211213211321223112111311222112132113212221132221222112112322211211131221131211132221232112111312111213111213211231131112311311221122132113213221133112132123222112311311222113111231132231121113112221121321133112132112211213322112111312211312111322212321121113121112131112132112311321322112111312212321121113122122211211232221121311121312211213211312111322211213211321322123211211131211121332211213211321322113311213211322132112311321322112111312212321121113122122211211232221121321132132211331121321231231121113112221121321133112132112312321123113112221121113122113111231133221121321132122311211131122211213211321222113222122211211232221123113112221131112311332111213122112311311123112111331121113122112132113121113222112311311221112131221123113112221121113311211131122211211131221131211132221121321132132212321121113121112133221123113112221131112311332111213213211221113122113121113222112132113213221232112111312111213322112132113213221133112132123123112111312211322311211133112111312212221121123222112132113213221133112132123222113223113112221131112311332111213122112311311123112112322211211131221131211132221232112111312111213111213211231132132211211131221131211221321123113213221123113112221131112211322212322211231131122211322111312211312111322211213211321322113311213211331121113122122211211132213211231131122212322211331222113112211"
-    );
-  });
+    ]
+  ]);
+
+  for (const [n, expected] of TEST_CASES) {
+    it(`returns ${expected} when called with ${n}`, () => {
+      expect(countAndSay(n)).toBe(expected);
+    });
+  }
 });

solutions/countCompleteTreeNodes.test.ts

@@ -2,19 +2,16 @@ import { createBinaryTreeNode } from "../utilities/TreeNode";
 import countNodes from "./countCompleteTreeNodes";
 
 describe("222. Count Complete Tree Nodes", () => {
-  test("#1", () => {
-    expect(countNodes(createBinaryTreeNode([1, 2, 3, 4, 5, 6]))).toBe(6);
-  });
+  const TEST_CASES = new Map([
+    [[1, 2, 3, 4, 5, 6], 6],
+    [[], 0],
+    [[1, 2, 3, 4, 5, 6, 7, 8], 8],
+    [[1, 2, 3, 4, 5, 6, 7], 7]
+  ]);
 
-  test("#2", () => {
-    expect(countNodes(null)).toBe(0);
-  });
-
-  test("#3", () => {
-    expect(countNodes(createBinaryTreeNode([1, 2, 3, 4, 5, 6, 7, 8]))).toBe(8);
-  });
-
-  test("#4", () => {
-    expect(countNodes(createBinaryTreeNode([1, 2, 3, 4, 5, 6, 7]))).toBe(7);
-  });
+  for (const [values, expected] of TEST_CASES) {
+    it(`returns ${expected} when called with [${values}]`, () => {
+      expect(countNodes(createBinaryTreeNode(values))).toBe(expected);
+    });
+  }
 });

solutions/diameterOfBinaryTree.test.ts

@@ -2,54 +2,50 @@ import { createBinaryTreeNode } from "../utilities/TreeNode";
 import diameterOfBinaryTree from "./diameterOfBinaryTree";
 
 describe("543. Diameter of Binary Tree", () => {
-  test("#1", () => {
-    expect(diameterOfBinaryTree(createBinaryTreeNode([1, 2, 3, 4, 5]))).toBe(3);
-  });
+  const TEST_CASES = new Map([
+    [[1, 2, 3, 4, 5], 3],
+    [[1], 0],
+    [[], 0],
+    [
+      [
+        4,
+        -7,
+        -3,
+        null,
+        null,
+        -9,
+        -3,
+        9,
+        -7,
+        -4,
+        null,
+        6,
+        null,
+        -6,
+        -6,
+        null,
+        null,
+        0,
+        6,
+        5,
+        null,
+        9,
+        null,
+        null,
+        -1,
+        -4,
+        null,
+        null,
+        null,
+        -2
+      ],
+      8
+    ]
+  ]);
 
-  test("#2", () => {
-    expect(diameterOfBinaryTree(createBinaryTreeNode([1]))).toBe(0);
-  });
-
-  test("#3", () => {
-    expect(diameterOfBinaryTree(null)).toBe(0);
-  });
-
-  test("#4", () => {
-    expect(
-      diameterOfBinaryTree(
-        createBinaryTreeNode([
-          4,
-          -7,
-          -3,
-          null,
-          null,
-          -9,
-          -3,
-          9,
-          -7,
-          -4,
-          null,
-          6,
-          null,
-          -6,
-          -6,
-          null,
-          null,
-          0,
-          6,
-          5,
-          null,
-          9,
-          null,
-          null,
-          -1,
-          -4,
-          null,
-          null,
-          null,
-          -2
-        ])
-      )
-    ).toBe(8);
-  });
+  for (const [values, expected] of TEST_CASES) {
+    it(`returns ${expected} when called with [${values}]`, () => {
+      expect(diameterOfBinaryTree(createBinaryTreeNode(values))).toBe(expected);
+    });
+  }
 });