small code improvements

Author: vyuldashev

src/VladimirYuldashev/LaravelQueueRabbitMQ/Queue/RabbitMQQueue.php

@@ -111,7 +111,7 @@ public function pushRaw($payload, $queue = null, array $options = [])
                 'delivery_mode' => 2,
             ];
 
-            if (isset($this->attempts) === true) {
+            if ($this->attempts !== null) {
                 $headers['application_headers'] = [self::ATTEMPT_COUNT_HEADERS_KEY => ['I', $this->attempts]];
             }
 
@@ -204,7 +204,7 @@ private function declareQueue($name)
         $name = $this->getQueueName($name);
         $exchange = $this->configExchange['name'] ?: $name;
 
-        if ($this->declareExchange && !in_array($exchange, $this->declaredExchanges)) {
+        if ($this->declareExchange && !in_array($exchange, $this->declaredExchanges, true)) {
             // declare exchange
             $this->channel->exchange_declare(
                 $exchange,
@@ -217,7 +217,7 @@ private function declareQueue($name)
             $this->declaredExchanges[] = $exchange;
         }
 
-        if ($this->declareBindQueue && !in_array($name, $this->declaredQueues)) {
+        if ($this->declareBindQueue && !in_array($name, $this->declaredQueues, true)) {
             // declare queue
             $this->channel->queue_declare(
                 $name,
@@ -240,7 +240,7 @@ private function declareQueue($name)
      * @param string $destination
      * @param DateTime|int $delay
      *
-     * @return string
+     * @return array
      */
     private function declareDelayedQueue($destination, $delay)
     {
@@ -251,7 +251,7 @@ private function declareDelayedQueue($destination, $delay)
         $exchange = $this->configExchange['name'] ?: $destination;
 
         // declare exchange
-        if (!in_array($exchange, $this->declaredExchanges)) {
+        if (!in_array($exchange, $this->declaredExchanges, true)) {
             $this->channel->exchange_declare(
                 $exchange,
                 $this->configExchange['type'],
@@ -262,7 +262,7 @@ private function declareDelayedQueue($destination, $delay)
         }
 
         // declare queue
-        if (!in_array($name, $this->declaredQueues)) {
+        if (!in_array($name, $this->declaredQueues, true)) {
             $this->channel->queue_declare(
                 $name,
                 $this->configQueue['passive'],
@@ -315,7 +315,7 @@ public function setCorrelationId($id)
      */
     public function getCorrelationId()
     {
-        return $this->correlationId ?: uniqid();
+        return $this->correlationId ?: uniqid('', true);
     }
 
     /**

tests/RabbitMQQueueTest.php

@@ -83,7 +83,7 @@ public function test_push()
 
         $correlationId = $this->queue->push($job, $data);
 
-        $this->assertEquals(13, strlen($correlationId));
+        $this->assertEquals(23, strlen($correlationId));
     }
 
     public function test_later()
@@ -120,7 +120,7 @@ public function test_later()
 
         $correlationId = $this->queue->later($delay, $job, $data);
 
-        $this->assertEquals(13, strlen($correlationId));
+        $this->assertEquals(23, strlen($correlationId));
     }
 
     public function test_pop()