Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: aws-cdk@v2.1029.4
Choose a base ref
...
head repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: aws-cdk@v2.1030.0
Choose a head ref
  • 7 commits
  • 86 files changed
  • 15 contributors

Commits on Oct 6, 2025

  1. chore(cli): add cdk flags to readme command list (#899)

    the docs are already in the readme, just don't show up in the list
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    kaizencc authored Oct 6, 2025
    Configuration menu
    Copy the full SHA
    ab4a08f View commit details
    Browse the repository at this point in the history
  2. feat(cli): allow users to enable all feature flags that do not impact…

    … their application (#798)
    
    Allows users to run `cdk flags --safe` to set all unconfigured feature
    flags to their recommended states without changing their CloudFormation
    template.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Co-authored-by: Rico Huijbers <rix0rrr@gmail.com>
    vivian12300 and rix0rrr authored Oct 6, 2025
    Configuration menu
    Copy the full SHA
    05954dd View commit details
    Browse the repository at this point in the history
  3. refactor(toolkit-lib): standardize confirmation requests to use Confi…

    …rmationRequest interface (#904)
    
    This PR standardizes user confirmation flows across the CDK CLI by
    migrating from ad-hoc `promptly.confirm` usage to the structured
    `ConfirmationRequest` interface.
    
    These are the changes as suggested here:
    #826 (review)
    
    ## Changes
    
    - **Convert CDK_TOOLKIT_I8910**: Changed from `DataRequest` to
    `ConfirmationRequest` for refactor confirmation
    - **Standardize destroy flow**: Replace `promptly.confirm` with
    `IO.CDK_TOOLKIT_I7010` message
    - **Standardize deploy flow**: Update `askUserConfirmation` to use
    `ActionLessRequest<ConfirmationRequest>` pattern
    - **Clean up test infrastructure**: Remove deprecated `markTesting`
    function and `TESTING` variable
    - **Update tests**: Replace `promptly` mocks with `requestSpy` for
    consistency
    
    ## Benefits
    
    - Consistent user interaction patterns across all CLI commands
    - Better testability through standardized mocking
    - Improved error handling and TTY detection through the IO system
    - Cleaner separation of concerns between UI logic and business logic
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Oct 6, 2025
    Configuration menu
    Copy the full SHA
    9855c8f View commit details
    Browse the repository at this point in the history
  4. chore(cli-lib-alpha): stop releasing deprecated package (#905)

    Stop releasing the deprecated `@aws-cdk/cli-lib-alpha` package. This
    change removes the package from the code base and integ tests. If we
    ever need to release it again, we can revert this PR.
    
    I tried to just disable releasing, but then integ tests fail and I think
    removing it all in one PR is just easier if we need to go back to it.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Oct 6, 2025
    Configuration menu
    Copy the full SHA
    3177fd0 View commit details
    Browse the repository at this point in the history
  5. feat(integ-runner): use toolkit-lib as default engine (#906)

    This PR makes the toolkit-lib engine the default for integ-runner,
    replacing the previous cli-wrapper engine.
    
    ## Changes
    
    - **Default engine switch**:  is now the default engine instead of 
    - **Deprecation path**: Added unstable flag to temporarily revert to the
    old engine
    - **User guidance**: Added helpful error messages and deprecation
    warnings to guide users through the transition
    - **Test updates**: Updated test suite to reflect the new default engine
    
    ## Migration Path
    
    Users experiencing issues with the new default engine can temporarily
    revert using:
    ```
    --unstable=deprecated-cli-engine
    ```
    
    The old engine is scheduled for removal in January 2026.
    
    ## Error Handling
    
    When errors occur with the new engine, users receive guidance on how to
    report issues and temporarily revert if needed.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Oct 6, 2025
    Configuration menu
    Copy the full SHA
    a6fa914 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2025

  1. fix(cli): metadata path in generated templates is invalid for migrate…

    … command (#909)
    
    Fixes #902 
    
    The path to the template Id had been changed by CloudFormation so
    migrate.json was not being generated correctly.
    
    Old format:
    ```
    Metadata:
      TemplateId: <arn>
    ```
    New format:
    ```
    Metadata:
      AWSToolsMetrics:
        IaC_Generator: <arn>
    ```
    We do not have a test that would have caught this because the resource
    scan can take such a long time that it was causing errors in our tests
    when it did exist.
    
    Adding a new test for this is something we should look into but it will
    likely require a new test account that is empty except for test
    resources so that the test will run fast enough.
    
    I tested this change manually and we now have all the data we need in
    migrate.json again (edited to remove all actual identifying
    information):
    ```
    {
      "//": "This file is generated by cdk migrate. It will be automatically deleted after the first successful deployment of this app to the environment of the original resources.",
      "Source": "arn:aws:cloudformation:ap-southeast-1:xxxxxxxxx:generatedTemplate/xxxxxxxx",
      "Resources": [
        {
          "ResourceType": "AWS::SQS::Queue",
          "LogicalResourceId": "SQSQueueSimpleStackBarapsoutheast1b",
          "ResourceIdentifier": {
            "QueueUrl": "https://sqs.ap-southeast-1.amazonaws.com/xxxxxxxx/SimpleStack-Bar-ap-southeast-1b"
          }
        },
        {
          "ResourceType": "AWS::SQS::Queue",
          "LogicalResourceId": "SQSQueueCdkfromcfne2etestSimpleStackgolangBarapsoutheast1b",
          "ResourceIdentifier": {
            "QueueUrl": "https://sqs.ap-southeast-1.amazonaws.com/xxxxxxxxx/cdk-from-cfn-e2e-test-SimpleStack-golang-Bar-ap-southeast-1b"
          }
        }
      ]
    }
    ```
    
    and the diff shows:
    ```
    new-app-test % cdk diff
    Stack new-app-test
    Parameters and rules created during migration do not affect resource configuration.
    Parameters
    [+] Parameter BootstrapVersion BootstrapVersion: {"Type":"AWS::SSM::Parameter::Value<String>","Default":"/cdk-bootstrap/hnb659fds/version","Description":"Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]"}
    
    Resources
    [←] AWS::SQS::Queue SQSQueueCdkfromcfne2etestSimpleStackgolangBarapsoutheast1b SQSQueueCdkfromcfne2etestSimpleStackgolangBarapsoutheast1b import
    [←] AWS::SQS::Queue SQSQueueSimpleStackBarapsoutheast1b SQSQueueSimpleStackBarapsoutheast1b import
    
    
    
    ✨  Number of stacks with differences: 1
    ```
    with the deployment logs:
    ```
    new-app-test % cdk deploy
    
    ✨  Synthesis time: 4.3s
    
    new-app-test: creating stack for resource migration...
    new-app-test: importing resources into stack...
    new-app-test: creating CloudFormation changeset...
    
     ✅  new-app-test
    '
    ✨  Resource migration time: 53.54s
    '
    new-app-test: applying CDKMetadata and Outputs to stack (if applicable)...
    new-app-test: start: Building new-app-test Template
    new-app-test: success: Built new-app-test Template
    new-app-test: start: Publishing new-app-test Template (current_account-ap-southeast-1-dcf01c72)
    new-app-test: success: Published new-app-test Template (current_account-ap-southeast-1-dcf01c72)
    new-app-test: deploying... [1/1]
    
     ✅  new-app-test (no changes)
    
    ✨  Deployment time: 1.41s
    
    Stack ARN:
    arn:aws:cloudformation:ap-southeast-1:xxxxxxxxx:stack/new-app-test/xxxxxxxx
    ```
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    TheRealAmazonKendra authored Oct 7, 2025
    Configuration menu
    Copy the full SHA
    d530564 View commit details
    Browse the repository at this point in the history
  2. feat(cli): auto-detect language for single-language custom templates (#…

    …819)
    
    Updated `cdk init` command to auto-detect language for single-language
    custom templates that are pulled from filesystem using `--from-path` so
    users do not need to specify `--language` in this case.
    
    Fixes #
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <github-actions@github.com>
    Co-authored-by: Ian Hou <45278651+iankhou@users.noreply.github.com>
    Co-authored-by: AWS CDK Automation <43080478+aws-cdk-automation@users.noreply.github.com>
    Co-authored-by: github-actions <github-actions@github.com>
    Co-authored-by: Eli Polonsky <Eli.polonsky@gmail.com>
    Co-authored-by: Otavio Macedo <288203+otaviomacedo@users.noreply.github.com>
    Co-authored-by: Pahud Hsieh <pahudnet@gmail.com>
    Co-authored-by: Momo Kornher <mail@moritzkornher.de>
    Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
    Co-authored-by: Rico Hermans <rix0rrr@gmail.com>
    Co-authored-by: Dhyan Gandhi <gandhidhyan@gmail.com>
    Co-authored-by: Dhyan Gandhi <gandhya@amazon.com>
    Co-authored-by: Kaizen Conroy <36202692+kaizencc@users.noreply.github.com>
    Co-authored-by: vivian12300 <80646164+vivian12300@users.noreply.github.com>
    14 people authored Oct 7, 2025
    Configuration menu
    Copy the full SHA
    e46adaf View commit details
    Browse the repository at this point in the history
Loading