Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: @aws-cdk/toolkit-lib@v1.1.1
Choose a base ref
...
head repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: @aws-cdk/toolkit-lib@v1.1.2
Choose a head ref
  • 19 commits
  • 116 files changed
  • 6 contributors

Commits on Jun 12, 2025

  1. fix(cdk-assets): pin minimatch to 10.0.1 (#601)

    Fixes #597 
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    iankhou authored Jun 12, 2025
    Configuration menu
    Copy the full SHA
    65e802f View commit details
    Browse the repository at this point in the history
  2. chore: run Amplify smoke tests only on Node 20 (#604)

    On recent Node 22s, they fail with the following weird error:
    
    ```
     [BackendBuildError] Unable to deploy due to CDK Assembly Error
        ∟ Caused by: [_AssemblyError] Assembly builder failed
      Error: aused by: [Error] ENOENT: no such file or directory, open '/tmp/cdk-integ-0dbc757n71oo/node_modules/@aws-amplify/backend-output-storage/lib/index.js?tsx-namespace=1749655833950'
    ```
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    rix0rrr authored Jun 12, 2025
    Configuration menu
    Copy the full SHA
    5c4ce36 View commit details
    Browse the repository at this point in the history
  3. chore(toolkit-lib): include declaration maps so that API extractor ca…

    …n locate the source file (#592)
    
    With this change
    
    ```
    "fileUrlPath": "lib/payloads/hotswap.d.ts",
    ```
    
    becomes
    
    ```
    "fileUrlPath": "lib/payloads/hotswap.ts",
    ```
    
    in `toolkit-lib.api.json`.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    Co-authored-by: Ian Hou <45278651+iankhou@users.noreply.github.com>
    mrgrain and iankhou authored Jun 12, 2025
    Configuration menu
    Copy the full SHA
    e243b11 View commit details
    Browse the repository at this point in the history
  4. chore(integ-runner): prepare integ-runner for different engines (#605)

    Updates the engine contract `ICli` to support other engines. The main
    change here is to make all methods async. For `watch` this required some
    more changes and a switch to a callback based system instead of
    returning and EventEmitter. Finally the PR changes the return type of
    `list` to be an array of stack names instead of a newline separated
    string.
    
    Due to the "viral" nature of async/await, this touches a lot of code
    paths.
    
    Contains some related clean-up:
    
    - simplified the mock engine `MockCdkMocks` to not depend on the anyway
    unused `CdkCliWrapper` any more
    - set `isolatedModules` in tsconfig instead of jest in `integ-runner`
    - Remove duplicated command input types from `cdk-cli-wrapper` in favor
    of the same types from `@aws-cdk/cloud-assembly-schema`
    
    After this change is in, it will be possible to implement an engine
    based on toolkit-lib.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Jun 12, 2025
    Configuration menu
    Copy the full SHA
    9545430 View commit details
    Browse the repository at this point in the history
  5. chore(integ-testing): skip "amplify integration" test because it is f…

    …ailing due to an upstream error (#606)
    
    Upstream problem:
    aws-amplify/amplify-backend#2849
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Jun 12, 2025
    Configuration menu
    Copy the full SHA
    73e5e36 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2025

  1. feat(cloud-assembly-schema): add feature flag report as a possible ar…

    …tifact (#590)
    
    This gives libraries the opportunity to report the feature flags they
    support, and what values they saw during synthesis.
    
    I purposely did not bump the schema version, since I want this feature
    to be fully incremental without disturbing existing users: there is no
    consumption of this new schema yet, that will come later, but we don't
    want to force people to upgrade their CLI's unnecessarily. That's bad
    DX.
    
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <github-actions@github.com>
    Co-authored-by: github-actions <github-actions@github.com>
    Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
    3 people authored Jun 13, 2025
    Configuration menu
    Copy the full SHA
    e272c5e View commit details
    Browse the repository at this point in the history
  2. chore: update PR lint workflow and projenrc with package scopes (#609)

    This PR updates the PR lint workflow and projenrc configuration to
    dynamically generate the list of allowed scopes based on the monorepo
    packages.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Jun 13, 2025
    Configuration menu
    Copy the full SHA
    03378bc View commit details
    Browse the repository at this point in the history
  3. chore(node-bundle): produce a bundle metafile by default (#607)

    Small QoL improvement so that engineers always have an esbuild bundle
    metafile available to [analyze](https://esbuild.github.io/analyze/).
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Jun 13, 2025
    Configuration menu
    Copy the full SHA
    c64f63a View commit details
    Browse the repository at this point in the history
  4. feat(cli): aws-cdk bundle is now targeting node18 (#610)

    Editorial changes to the CLI readme to ensure this will end-up in the
    correct release notes.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Jun 13, 2025
    Configuration menu
    Copy the full SHA
    bdf1f66 View commit details
    Browse the repository at this point in the history
  5. fix(cli): retain type of context values and not convert them to string (

    #595)
    
    Fixes [#30583](aws/aws-cdk#30583)
    
    CLI’s context-passing mechanism relied on serialising every entry to a
    "KEY=VALUE" string, leading CLI to only allows passing string context,
    so even JSON booleans (true/false) and numbers became plain strings.
    This resulted in losing the typed context, like boolean feature-flags
    are always being passed as string "true"/"false". This incorrectly
    passed feature flags caused certain integration tests snapshot in the
    [aws-cdk](https://github.com/aws/aws-cdk/tree/main/packages/%40aws-cdk-testing/framework-integ)
    library to be updated with incorrect values causing the integration
    tests to fail.
    
    This fix retains the type of context values when passed via CLI, by
    correctly JSON parsing the context while building user configuration.
    Values that aren’t valid JSON will fall back to plain strings, so
    existing workflows should continue working as is. This will restore
    correct typing for feature flags without disrupting existing tests.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
    kumsmrit and mrgrain authored Jun 13, 2025
    Configuration menu
    Copy the full SHA
    6250b39 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2025

  1. chore: fix logs upload for Node smoke tests (#613)

    We used to upload logs with the name of the suite we're running, but now
    that we are running the same suite multiple times with different node
    versions it's possible to get the following error:
    
    ```
    Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
    ```
    
    We need to make the logs entirely unique by including all matrix
    parameters.
    
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    rix0rrr authored Jun 15, 2025
    Configuration menu
    Copy the full SHA
    11579fd View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2025

  1. chore: slugify artifact ID (#614)

    In #613 we made the artifact ID unique for different Node versions, but
    the characters in `lts/*` aren't all safe for inclusion in the artifact
    ID.
    
    Slugify the artifact ID first before using it.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    rix0rrr authored Jun 16, 2025
    Configuration menu
    Copy the full SHA
    05731b5 View commit details
    Browse the repository at this point in the history
  2. chore(deps): upgrade dependencies (#615)

    Upgrades project dependencies. See details in [workflow run].
    
    [Workflow Run]:
    https://github.com/aws/aws-cdk-cli/actions/runs/15669014073
    
    ------
    
    *Automatically created by projen via the "upgrade" workflow*
    
    ---------
    
    Signed-off-by: github-actions <github-actions@github.com>
    Co-authored-by: github-actions <github-actions@github.com>
    Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
    3 people authored Jun 16, 2025
    Configuration menu
    Copy the full SHA
    fafb1f6 View commit details
    Browse the repository at this point in the history
  3. chore(toolkit-lib): set test timeout to 10s (#618)

    Any tests that synth an assembly require a little longer to run. Let's
    just acknowledge that. Otherwise we keep running into test failures due
    to timeouts locally.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Jun 16, 2025
    Configuration menu
    Copy the full SHA
    85979f2 View commit details
    Browse the repository at this point in the history
  4. chore: slugify step must be run even if workflow is failing (#619)

    The title says it all :)
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <github-actions@github.com>
    Co-authored-by: github-actions <github-actions@github.com>
    rix0rrr and github-actions authored Jun 16, 2025
    Configuration menu
    Copy the full SHA
    7c48131 View commit details
    Browse the repository at this point in the history
  5. chore(integ-testing): take Verdaccio config from script file instead …

    …of workflow (#608)
    
    This makes it possible to change the package config on a branch, and
    test it, without having to merge workflow changes to `main` to properly
    pick up that new package.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    rix0rrr authored Jun 16, 2025
    Configuration menu
    Copy the full SHA
    75ab160 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2025

  1. Configuration menu
    Copy the full SHA
    2aae293 View commit details
    Browse the repository at this point in the history
  2. chore: script needs to be made executable (#622)

    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    rix0rrr authored Jun 17, 2025
    Configuration menu
    Copy the full SHA
    3f8110f View commit details
    Browse the repository at this point in the history
  3. chore: use isolatedModules tsconfig everywhere (#620)

    Replaces the deprecated `ts-jest` config of the same name.
    
    Also includes some small alignments of `tsconfig.dev.json` files with
    their corresponding parent, where previously missed.
    Also removes `dom` from `integ-runner` since this is not needed.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Co-authored-by: Rico Hermans <rix0rrr@gmail.com>
    mrgrain and rix0rrr authored Jun 17, 2025
    Configuration menu
    Copy the full SHA
    e9c24a6 View commit details
    Browse the repository at this point in the history
Loading