Merge pull request KnpLabs#442 from naderman/t/hook-update-no-name

cursedcoder · web-flow · commit 8da9b0db09dd · 2016-10-14T18:57:56.000+08:00
name is not an argument on updating a hook
diff --git a/lib/Github/Api/Repository/Hooks.php b/lib/Github/Api/Repository/Hooks.php
@@ -32,8 +32,8 @@ public function create($username, $repository, array $params)
 
     public function update($username, $repository, $id, array $params)
     {
-        if (!isset($params['name'], $params['config'])) {
-            throw new MissingArgumentException(array('name', 'config'));
+        if (!isset($params['config'])) {
+            throw new MissingArgumentException(array('config'));
         }
 
         return $this->patch('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/hooks/'.rawurlencode($id), $params);

Original file line number	Diff line number	Diff line change
`@@ -32,8 +32,8 @@ public function create($username, $repository, array $params)`
`32`	`32`
`33`	`33`	`public function update($username, $repository, $id, array $params)`
`34`	`34`	`{`
`35`		`- if (!isset($params['name'], $params['config'])) {`
`36`		`- throw new MissingArgumentException(array('name', 'config'));`
	`35`	`+ if (!isset($params['config'])) {`
	`36`	`+ throw new MissingArgumentException(array('config'));`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`return $this->patch('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/hooks/'.rawurlencode($id), $params);`