Skip to content

Commit 0a1d3bd

Browse files
committed
Rename config type.
1 parent 53e2936 commit 0a1d3bd

10 files changed

+21
-20
lines changed

jscomp/gentype/EmitType.ml

+6-6
Original file line numberDiff line numberDiff line change
@@ -13,22 +13,22 @@ let fileHeader ~sourceFile =
1313
~lines:[ "TypeScript file generated from " ^ sourceFile ^ " by genType." ]
1414
^ "/* eslint-disable import/first */\n\n"
1515

16-
let generatedFilesExtension ~(config : Config.config) =
16+
let generatedFilesExtension ~(config : Config.t) =
1717
match config.generatedFileExtension with
1818
| Some s ->
1919
(* from .foo.bar to .foo *)
2020
Filename.remove_extension s
2121
| None -> ".gen"
2222

23-
let outputFileSuffix ~(config : Config.config) =
23+
let outputFileSuffix ~(config : Config.t) =
2424
match config.generatedFileExtension with
2525
| Some s when Filename.extension s <> "" (* double extension *) -> s
2626
| _ -> generatedFilesExtension ~config ^ ".tsx"
2727

2828
let generatedModuleExtension ~config = generatedFilesExtension ~config
2929
let shimExtension = ".shim.ts"
3030

31-
let interfaceName ~(config: Config.config) name =
31+
let interfaceName ~(config: Config.t) name =
3232
match config.exportInterfaces with true -> "I" ^ name | false -> name
3333

3434
let typeAny = ident ~builtin:true "any"
@@ -73,7 +73,7 @@ let isTypeReactRef ~fields =
7373
let isTypeFunctionComponent ~fields type_ =
7474
type_ |> isTypeReactElement && not (isTypeReactRef ~fields)
7575

76-
let rec renderType ~(config: Config.config) ?(indent = None) ~typeNameIsInterface ~inFunType
76+
let rec renderType ~(config: Config.t) ?(indent = None) ~typeNameIsInterface ~inFunType
7777
type0 =
7878
match type0 with
7979
| Array (t, arrayKind) ->
@@ -280,7 +280,7 @@ let emitExportConst ~early ?(comment = "") ~config ?(docString = "") ~emitters
280280
let emitExportDefault ~emitters name =
281281
"export default " ^ name ^ ";" |> Emitters.export ~emitters
282282
283-
let emitExportType ~(config: Config.config) ~emitters ~nameAs ~opaque ~type_ ~typeNameIsInterface
283+
let emitExportType ~(config: Config.t) ~emitters ~nameAs ~opaque ~type_ ~typeNameIsInterface
284284
~typeVars resolvedTypeName =
285285
let typeParamsString = EmitText.genericsString ~typeVars in
286286
let isInterface = resolvedTypeName |> typeNameIsInterface in
@@ -334,7 +334,7 @@ let emitImportValueAsEarly ~emitters ~name ~nameAs importPath =
334334
^ "';"
335335
|> Emitters.requireEarly ~emitters
336336
337-
let emitRequire ~importedValueOrComponent ~early ~emitters ~(config: Config.config) ~moduleName
337+
let emitRequire ~importedValueOrComponent ~early ~emitters ~(config: Config.t) ~moduleName
338338
importPath =
339339
let commentBeforeRequire =
340340
match importedValueOrComponent with

jscomp/gentype/ExportModule.ml

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ and exportModuleItemToFields =
6363
let fieldForValue = {fieldForType with type_ = typeForValue} in
6464
{fieldForValue; fieldForType; needsConversion} :: fields)
6565
exportModuleItem []
66-
: config:Config.config -> exportModuleItem -> fieldInfo list)
66+
: config:Config.t -> exportModuleItem -> fieldInfo list)
6767

6868
let rec extendExportModuleItem x ~converter
6969
~(exportModuleItem : exportModuleItem) ~type_ ~valueName =

jscomp/gentype/GenTypeCommon.ml

+1-1
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ struct
144144
Some (packageName |> namespace_of_package_name)
145145
else None
146146

147-
let isGeneratedModule id ~(config : Config.config) =
147+
let isGeneratedModule id ~(config : Config.t) =
148148
config.bsDependencies
149149
|> List.exists (fun packageName ->
150150
packageName |> packageNameToGeneratedModuleName

jscomp/gentype/GenTypeConfig.ml

+3-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module ModuleNameMap = Map.Make (ModuleName)
33
type module_ = CommonJS | ES6
44
type bsVersion = int * int * int
55

6-
type config = {
6+
type t = {
77
mutable bsbProjectRoot : string;
88
bsDependencies : string list;
99
mutable emitImportCurry : bool;
@@ -92,7 +92,8 @@ let rec findProjectRoot ~dir =
9292
let parent = dir |> Filename.dirname in
9393
if parent = dir then (
9494
prerr_endline
95-
("Error: cannot find project root containing " ^ compilerConfigFile ^ ".");
95+
("Error: cannot find project root containing " ^ compilerConfigFile
96+
^ ".");
9697
assert false)
9798
else findProjectRoot ~dir:parent
9899

jscomp/gentype/ImportPath.ml

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ let chopExtensionSafe s =
1818

1919
let dump (dir, s) = NodeFilename.concat dir s
2020

21-
let toCmt ~(config : Config.config) ~outputFileRelative (dir, s) =
21+
let toCmt ~(config : Config.t) ~outputFileRelative (dir, s) =
2222
let open Filename in
2323
concat
2424
(outputFileRelative |> dirname)

jscomp/gentype/ImportPath.mli

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ open GenTypeCommon
22

33
type t
44

5-
val bsCurryPath : config:Config.config -> t
5+
val bsCurryPath : config:Config.t -> t
66
val dump : t -> string
77
val emit : t -> string
88
val fromModule : dir:string -> importExtension:string -> ModuleName.t -> t
99
val fromStringUnsafe : string -> t
10-
val toCmt : config:Config.config -> outputFileRelative:string -> t -> string
10+
val toCmt : config:Config.t -> outputFileRelative:string -> t -> string

jscomp/gentype/ModuleResolver.ml

+4-4
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ let readBsDependenciesDirs ~root =
1717

1818
type pkgs = { dirs : string list; pkgs : (string, string) Hashtbl.t }
1919

20-
let readDirsFromConfig ~(config : Config.config) =
20+
let readDirsFromConfig ~(config : Config.t) =
2121
let dirs = ref [] in
2222
let root = config.projectRoot in
2323
let ( +++ ) = Filename.concat in
@@ -51,7 +51,7 @@ let readDirsFromConfig ~(config : Config.config) =
5151
| None -> ());
5252
!dirs
5353

54-
let readSourceDirs ~(config : Config.config) =
54+
let readSourceDirs ~(config : Config.t) =
5555
let sourceDirs =
5656
[ "lib"; "bs"; ".sourcedirs.json" ]
5757
|> List.fold_left ( +++ ) config.bsbProjectRoot
@@ -196,7 +196,7 @@ let apply ~resolver ~useBsDependencies moduleName =
196196

197197
(** Resolve a reference to ModuleName, and produce a path suitable for require.
198198
E.g. require "../foo/bar/ModuleName.ext" where ext is ".re" or ".js". *)
199-
let resolveModule ~(config : Config.config) ~importExtension ~outputFileRelative
199+
let resolveModule ~(config : Config.t) ~importExtension ~outputFileRelative
200200
~resolver ~useBsDependencies moduleName =
201201
let outputFileRelativeDir =
202202
(* e.g. src if we're generating src/File.re.js *)
@@ -264,7 +264,7 @@ let resolveGeneratedModule ~config ~outputFileRelative ~resolver moduleName =
264264
importPath
265265

266266
(** Returns the path to import a given Reason module name. *)
267-
let importPathForReasonModuleName ~(config : Config.config) ~outputFileRelative
267+
let importPathForReasonModuleName ~(config : Config.t) ~outputFileRelative
268268
~resolver moduleName =
269269
if !Debug.moduleResolution then
270270
Log_.item "Resolve Reason Module: %s\n" (moduleName |> ModuleName.toString);

jscomp/gentype/Paths.ml

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ let findNameSpace cmt =
2828
let getOutputFileRelative ~config cmt =
2929
(cmt |> handleNamespace) ^ EmitType.outputFileSuffix ~config
3030

31-
let getOutputFile ~(config : Config.config) cmt =
31+
let getOutputFile ~(config : Config.t) cmt =
3232
Filename.concat config.projectRoot (getOutputFileRelative ~config cmt)
3333

3434
let getModuleName cmt =

jscomp/gentype/Runtime.mli

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ val checkMutableObjectField : previousName:string -> name:string -> bool
1414

1515
val default : string
1616

17-
val emitModuleAccessPath : config:Config.config -> moduleAccessPath -> string
17+
val emitModuleAccessPath : config:Config.t -> moduleAccessPath -> string
1818

1919
val emitJSVariantGetLabel : polymorphic:bool -> string -> string
2020

jscomp/gentype/TypeEnv.mli

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ type t
55
val addModuleEquation : dep:dep -> internal:bool -> t -> unit
66
val addModulePath : typeEnv:t -> string -> ResolvedName.t
77
val addTypeEquations : typeEquations:(Longident.t * type_) list -> t -> t
8-
val applyTypeEquations : config:Config.config -> path:Path.t -> t -> type_ option
8+
val applyTypeEquations : config:Config.t -> path:Path.t -> t -> type_ option
99
val expandAliasToExternalModule : name:string -> t -> dep option
1010
val getModuleEquations : t -> ResolvedName.eq list
1111
val getModuleAccessPath : name:string -> t -> Runtime.moduleAccessPath

0 commit comments

Comments
 (0)