Skip to content

Conversation

@HamzaYslmn
Copy link
Contributor

Update Library

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

Hi @HamzaYslmn.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: other Something other than a library list request label Aug 5, 2023
@github-actions github-actions bot requested a review from per1234 August 5, 2023 17:50
@HamzaYslmn
Copy link
Contributor Author

HamzaYslmn commented Aug 5, 2023

WARNING: library.properties name value detaBaseArduinoESP8266 is longer than the recommended length of 16 characters.
See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
(Rule LP010)
WARNING: Library name detaBaseArduinoESP8266 contains "Arduino". This is superfluous.
See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
(Rule LP014)

I made some changes when it gave such a warning. I changed its name to detaBaseESP8266.
And HAMZA YESILMEN to Hamza Yesilmen
I request it to be examined.

2023/08/05 18:29:21 Scraping https://github.com/HamzaYslmn/detaBaseESP8266.git
2023/08/05 18:29:21 Checking out tag: V1.1.2
2023/08/05 18:29:21 Release detaBaseESP8266:1.1.2 has wrong library name, should be detaBaseArduinoESP8266

@HamzaYslmn HamzaYslmn changed the title Update Library Rename Library Name Aug 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

Hi @HamzaYslmn.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HamzaYslmn. I am confirming your request.

I created the pull request for the necessary changes at #3190. Since your pull request doesn't make any changes in the codebase, I'll go ahead and close it as superfluous, but it has already served its purpose to initiate the name change process.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge #3190 when it is done. You can subscribe to that pull request if you would like to get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@per1234 per1234 self-assigned this Aug 5, 2023
@per1234 per1234 added conclusion: invalid Issue/PR not valid topic: rename Change registered library name labels Aug 5, 2023
@per1234 per1234 closed this Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conclusion: invalid Issue/PR not valid topic: other Something other than a library list request topic: rename Change registered library name

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants