Use squash merge for submission PRs #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no good reason for a submission to consist of more than one commit. As the submitter works with the bot to produce a compliant submission, they will sometimes end up with PRs that consist of multiple non-atomic commits, which would pollute the repository's commit history if not squashed at the time of the merge.
github-actions
bot
added
other
and removed
type: enhancement
Contributor
|
Hi @per1234. If you intended to submit a library, please check the instructions and update your pull request if necessary: |
umbynos
approved these changes
Apr 27, 2021
silvanocerza
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no good reason for a submission to consist of more than one commit.
As the submitter works with the bot to produce a compliant submission, they will sometimes end up with PRs that consist
of multiple non-atomic commits, which would pollute the repository's commit history if not squashed at the time of the
merge.
Demo: per1234#27
GitHub API Reference:
https://docs.github.com/en/rest/reference/pulls#merge-a-pull-request