Skip to content

Commit f3a91c6

Browse files
committed
Use less ambiguous name for workflow job handling non-submission PRs
In the event a PR is detected as something other than a library submission, a review is requested from the Tooling Team and a comment is made to the PR thread explaining the situation. Previously, this job was named `request-review`. However, there are other circumstances under which a review will be requested (e.g., merge conflict). So this was not a very good job name. This job name is not referenced anywhere else in the workflow, so it currently only serves a documentation role and changing it has no functional effect.
1 parent 610ddd7 commit f3a91c6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/manage-prs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ jobs:
375375
team_reviewers: |
376376
- arduino/team_tooling
377377
378-
request-review:
378+
not-submission:
379379
needs:
380380
- parse
381381
if: needs.parse.outputs.type != 'submission' # These request types can't be automatically approved.

0 commit comments

Comments
 (0)