Skip to content

Conversation

@per1234
Copy link
Collaborator

@per1234 per1234 commented Oct 25, 2020

This provides some checks on how the entire action works with GitHub Actions, which can catch many issues the
unit/functional tests of the Python code will miss.

@per1234 per1234 added the type: enhancement Proposed improvement label Oct 25, 2020
@per1234 per1234 requested a review from giulcioffi October 25, 2020 13:47
@per1234 per1234 marked this pull request as draft October 25, 2020 15:57
This provides some checks on how the entire action works with GitHub Actions, which can catch issues the
unit/functional tests of the Python code will miss.
@per1234 per1234 marked this pull request as ready for review October 26, 2020 02:17
@per1234
Copy link
Collaborator Author

per1234 commented Oct 26, 2020

I plan to add checks of the sketches reports, but the deltas aspect of the report is dependent on the test sketches being present in the repository, so I'll submit the report checks as a separate PR after this is merged.

@giulcioffi giulcioffi merged commit 9fa3d42 into arduino:main Oct 26, 2020
@per1234 per1234 deleted the integration-test branch October 26, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants