move out of log group; change units of time

elapsed time is only output if compilation did not fail.

Author: 2bndy5

compilesketches/compilesketches.py

@@ -898,18 +898,11 @@ def compile_sketch(self, sketch_path, clean_build_cache):
         compilation_data = self.run_arduino_cli_command(
             command=compilation_command, enable_output=self.RunCommandOutput.NONE, exit_on_failure=False)
         diff_time = time.monotonic() - start_time
-        time_summary = ""
-        if diff_time > 60:
-            if diff_time > 360:
-                time_summary += f"{int(diff_time / 360)} hours "
-            time_summary += f"{int(diff_time / 60) % 60} minutes "
-        time_summary += f"{int(diff_time) % 60} seconds."
 
         # Group compilation output to make the log easy to read
         # https://github.com/actions/toolkit/blob/master/docs/commands.md#group-and-ungroup-log-lines
         print("::group::Compiling sketch:", path_relative_to_workspace(path=sketch_path))
         print(compilation_data.stdout)
-        print("Compilation time elapsed", time_summary)
         print("::endgroup::")
 
         class CompilationResult:
@@ -919,6 +912,14 @@ class CompilationResult:
 
         if not CompilationResult.success:
             print("::error::Compilation failed")
+        else:
+            time_summary = ""
+            if diff_time > 60:
+                if diff_time > 360:
+                    time_summary += f"{int(diff_time / 360)} h "
+                time_summary += f"{int(diff_time / 60) % 60} m "
+            time_summary += f"{int(diff_time) % 60} s"
+            print("Compilation time elapsed", time_summary)
 
         return CompilationResult()
 

compilesketches/tests/test_compilesketches.py

@@ -1435,11 +1435,12 @@ class CompilationData:
     expected_stdout = (
         "::group::Compiling sketch: " + str(compilesketches.path_relative_to_workspace(path=sketch_path)) + "\n"
         + str(stdout) + "\n"
-        + "Compilation time elapsed 0 seconds.\n"
         + "::endgroup::"
     )
     if not expected_success:
         expected_stdout += "\n::error::Compilation failed"
+    else:
+        expected_stdout += "\nCompilation time elapsed 0s"
     assert capsys.readouterr().out.strip() == expected_stdout
 
     assert compilation_result.sketch == sketch_path