From 3b1c9a38c444cb5c441bd43b10dce231751196f6 Mon Sep 17 00:00:00 2001 From: per1234 Date: Thu, 5 Aug 2021 03:18:02 -0700 Subject: [PATCH 1/2] Remove unused workflow variables These were artifacts left over from when the test workflow also generated the tester builds, but that process been moved to a dedicated workflow. --- .github/workflows/check-code-generation-task.yml | 3 --- .github/workflows/test-go-task.yml | 3 --- 2 files changed, 6 deletions(-) diff --git a/.github/workflows/check-code-generation-task.yml b/.github/workflows/check-code-generation-task.yml index 074b9e7c..c2cedfca 100644 --- a/.github/workflows/check-code-generation-task.yml +++ b/.github/workflows/check-code-generation-task.yml @@ -18,9 +18,6 @@ on: - "**/*.go" - "etc/schemas/**/*.json" -env: - BUILDS_ARTIFACT: build-artifacts - jobs: test-go: runs-on: ubuntu-latest diff --git a/.github/workflows/test-go-task.yml b/.github/workflows/test-go-task.yml index 8c07e24b..917c4f60 100644 --- a/.github/workflows/test-go-task.yml +++ b/.github/workflows/test-go-task.yml @@ -18,9 +18,6 @@ on: - "**/*.go" - "**/testdata/**" -env: - BUILDS_ARTIFACT: build-artifacts - jobs: test-go: strategy: From 7a9da9e65c99463ea70afb87413e7629296d1056 Mon Sep 17 00:00:00 2001 From: per1234 Date: Thu, 5 Aug 2021 03:02:06 -0700 Subject: [PATCH 2/2] Use workflow variables for tool versions in all workflows Placement of this information at the top of the file, where it is easy to find and edit, facilitates updates to the workflows as the tool version used for project development are bumped periodically. This is an established convention in the "template" workflows, but I missed some applications of it. I think it's most effective when done consistently throughout the workflows. --- .github/workflows/check-code-generation-task.yml | 6 +++++- .../workflows/deploy-cobra-mkdocs-versioned-poetry.yml | 6 +++++- .github/workflows/spell-check-task.yml | 6 +++++- .github/workflows/test-go-integration-task.yml | 10 ++++++++-- .github/workflows/test-go-task.yml | 6 +++++- 5 files changed, 28 insertions(+), 6 deletions(-) diff --git a/.github/workflows/check-code-generation-task.yml b/.github/workflows/check-code-generation-task.yml index c2cedfca..4035d94f 100644 --- a/.github/workflows/check-code-generation-task.yml +++ b/.github/workflows/check-code-generation-task.yml @@ -1,5 +1,9 @@ name: Check Code Generation +env: + # See: https://github.com/actions/setup-go/tree/v2#readme + GO_VERSION: "1.16" + on: push: paths: @@ -29,7 +33,7 @@ jobs: - name: Install Go uses: actions/setup-go@v2 with: - go-version: "1.16" + go-version: ${{ env.GO_VERSION }} - name: Install Taskfile uses: arduino/setup-task@v1 diff --git a/.github/workflows/deploy-cobra-mkdocs-versioned-poetry.yml b/.github/workflows/deploy-cobra-mkdocs-versioned-poetry.yml index 37726cb8..d26aafa0 100644 --- a/.github/workflows/deploy-cobra-mkdocs-versioned-poetry.yml +++ b/.github/workflows/deploy-cobra-mkdocs-versioned-poetry.yml @@ -1,6 +1,10 @@ # Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/deploy-cobra-mkdocs-versioned-poetry.md name: Deploy Website +env: + # See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python + PYTHON_VERSION: "3.9" + on: push: branches: @@ -52,7 +56,7 @@ jobs: - name: Install Python uses: actions/setup-python@v2 with: - python-version: "3.9" + python-version: ${{ env.PYTHON_VERSION }} - name: Install Poetry run: | diff --git a/.github/workflows/spell-check-task.yml b/.github/workflows/spell-check-task.yml index cdc79389..3b594353 100644 --- a/.github/workflows/spell-check-task.yml +++ b/.github/workflows/spell-check-task.yml @@ -1,6 +1,10 @@ # Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/spell-check-task.md name: Spell Check +env: + # See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python + PYTHON_VERSION: "3.9" + # See: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows on: push: @@ -22,7 +26,7 @@ jobs: - name: Install Python uses: actions/setup-python@v2 with: - python-version: "3.9" + python-version: ${{ env.PYTHON_VERSION }} - name: Install Poetry run: pip install poetry diff --git a/.github/workflows/test-go-integration-task.yml b/.github/workflows/test-go-integration-task.yml index 7664a0f0..4dd18710 100644 --- a/.github/workflows/test-go-integration-task.yml +++ b/.github/workflows/test-go-integration-task.yml @@ -1,5 +1,11 @@ name: Test Integration +env: + # See: https://github.com/actions/setup-go/tree/v2#readme + GO_VERSION: "1.16" + # See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python + PYTHON_VERSION: "3.9" + on: push: paths: @@ -40,7 +46,7 @@ jobs: - name: Install Go uses: actions/setup-go@v2 with: - go-version: "1.16" + go-version: ${{ env.GO_VERSION }} - name: Install Taskfile uses: arduino/setup-task@v1 @@ -51,7 +57,7 @@ jobs: - name: Install Python uses: actions/setup-python@v2 with: - python-version: "3.9" + python-version: ${{ env.PYTHON_VERSION }} - name: Install Poetry run: pip install poetry diff --git a/.github/workflows/test-go-task.yml b/.github/workflows/test-go-task.yml index 917c4f60..10b897f3 100644 --- a/.github/workflows/test-go-task.yml +++ b/.github/workflows/test-go-task.yml @@ -1,5 +1,9 @@ name: Run tests +env: + # See: https://github.com/actions/setup-go/tree/v2#readme + GO_VERSION: "1.16" + on: push: paths: @@ -36,7 +40,7 @@ jobs: - name: Install Go uses: actions/setup-go@v2 with: - go-version: "1.16" + go-version: ${{ env.GO_VERSION }} - name: Install Taskfile uses: arduino/setup-task@v1