Make the default value of the --recursive flag false

This may be the path of least astonishment.

Author: per1234

internal/cli/cli.go

@@ -35,7 +35,7 @@ func Root() *cobra.Command {
 	rootCommand.PersistentFlags().String("format", "text", "The output format can be {text|json}.")
 	rootCommand.PersistentFlags().String("library-manager", "", "Configure the rules for libraries in the Arduino Library Manager index. Can be {submit|update|false}.\nsubmit: Also run additional rules required to pass before a library is accepted for inclusion in the index.\nupdate: Also run additional rules required to pass before new releases of a library already in the index are accepted.\nfalse: Don't run any Library Manager-specific rules.")
 	rootCommand.PersistentFlags().String("project-type", "all", "Only check projects of the specified type and their subprojects. Can be {sketch|library|all}.")
-	rootCommand.PersistentFlags().Bool("recursive", true, "Search path recursively for Arduino projects to check. Can be {true|false}.")
+	rootCommand.PersistentFlags().Bool("recursive", false, "Search path recursively for Arduino projects to check. Can be {true|false}.")
 	rootCommand.PersistentFlags().String("report-file", "", "Save a report on the rules to this file.")
 	rootCommand.PersistentFlags().BoolP("verbose", "v", false, "Show more information while running rules.")
 	rootCommand.PersistentFlags().Bool("version", false, "Print version and timestamp of the build.")

test/test_all.py

@@ -26,9 +26,12 @@
 
 
 def test_defaults(run_command):
-    result = run_command(cmd=[], custom_working_dir=test_data_path.joinpath("recursive"))
+    result = run_command(cmd=[], custom_working_dir=test_data_path.joinpath("ValidSketch"))
     assert result.ok
 
+    result = run_command(cmd=[], custom_working_dir=test_data_path.joinpath("recursive"))
+    assert not result.ok
+
 
 @pytest.mark.parametrize(
     "project_folder, compliance_level",
@@ -115,16 +118,11 @@ def test_project_type_invalid(run_command):
 
 def test_recursive(run_command):
     valid_projects_path = test_data_path.joinpath("recursive")
-    result = run_command(cmd=["--recursive", "true", valid_projects_path])
-    assert result.ok
-
-    result = run_command(cmd=["--recursive", "false", valid_projects_path])
+    result = run_command(cmd=[valid_projects_path])
     assert not result.ok
 
-
-def test_recursive_invalid(run_command):
-    result = run_command(cmd=["--recursive", "foo", test_data_path.joinpath("ValidSketch")])
-    assert not result.ok
+    result = run_command(cmd=["--recursive", valid_projects_path])
+    assert result.ok
 
 
 def test_report_file(run_command, working_dir):
@@ -142,7 +140,6 @@ def test_report_file(run_command, working_dir):
             "--project-type",
             project_type,
             "--recursive",
-            "true",
             "--report-file",
             report_file_name,
             project_path,
@@ -206,7 +203,7 @@ def test_version(run_command):
 
 
 def test_arduino_lint_official(run_command):
-    project_path = test_data_path.joinpath("ARDUINO_LINT_OFFICIAL")
+    project_path = test_data_path.joinpath("ARDUINO_LINT_OFFICIAL", "Arduino_Lib")
 
     result = run_command(cmd=[project_path])
     assert not result.ok