Skip to content

Unintuitive dialogue on close with unsaved changes #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
UKHeliBob opened this issue Dec 12, 2021 · 1 comment
Closed

Unintuitive dialogue on close with unsaved changes #677

UKHeliBob opened this issue Dec 12, 2021 · 1 comment
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@UKHeliBob
Copy link

The standard Windows dialogue when closing an unsaved document is used by the classic IDE and offers 3 options, ie save changes Yes, No and Cancel and the default is Yes

image

The 3 options are very clear and the default is to save the changes

However, with IDE 2.0 the dialogue offers only 2 options, Yes and No
image

The default is still Yes, however, the logic is inverted compared to the standard dialogue and the default is for changes not to be saved, which I feel is wrong

Was there a reason for departing from the standard and inverting the logic ?

See https://forum.arduino.cc/t/ide-closing-dialogue/934992

@UKHeliBob UKHeliBob added the type: enhancement Proposed improvement label Dec 12, 2021
@per1234 per1234 added the topic: code Related to content of the project itself label Dec 12, 2021
@per1234 per1234 changed the title IDE version 2.0 closing dialogue Unintuitive dialogue on close with unsaved changes Dec 15, 2021
@per1234
Copy link
Contributor

per1234 commented Dec 15, 2022

This was resolved by #1351 but we didn't close this issue at that time.

The dialog whenever closing an IDE window would result in loss of sketch content now looks like this:

image

The default selection is the safe option of saving the sketch.

@per1234 per1234 closed this as completed Dec 15, 2022
@per1234 per1234 assigned per1234 and unassigned 91volt Dec 15, 2022
@per1234 per1234 added the conclusion: resolved Issue was resolved label Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

3 participants