Skip to content

Commit 79a5d22

Browse files
author
Akos Kitta
committedJul 20, 2020
fixed grpc client issue with the CLI config.
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
1 parent 537291b commit 79a5d22

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed
 

‎arduino-ide-extension/src/node/config-service-impl.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import * as fs from './fs-extra';
1313
import { spawnCommand } from './exec-util';
1414
import { RawData } from './cli-protocol/settings/settings_pb';
1515
import { SettingsClient } from './cli-protocol/settings/settings_grpc_pb';
16+
import * as serviceGrpcPb from './cli-protocol/settings/settings_grpc_pb';
1617
import { ConfigFileValidator } from './config-file-validator';
1718
import { ArduinoDaemonImpl } from './arduino-daemon-impl';
1819
import { DefaultCliConfig, CLI_CONFIG_SCHEMA_PATH, CLI_CONFIG } from './cli-config';
@@ -245,7 +246,10 @@ export class ConfigServiceImpl implements BackendApplicationContribution, Config
245246
}
246247

247248
protected async updateDaemon(port: string | number, config: DefaultCliConfig): Promise<void> {
248-
const client = new SettingsClient(`localhost:${port}`, grpc.credentials.createInsecure());
249+
// https://github.com/agreatfool/grpc_tools_node_protoc_ts/blob/master/doc/grpcjs_support.md#usage
250+
// @ts-ignore
251+
const SettingsClient = grpc.makeClientConstructor(serviceGrpcPb['cc.arduino.cli.settings.Settings'], 'SettingsService') as any;
252+
const client = new SettingsClient(`localhost:${port}`, grpc.credentials.createInsecure()) as SettingsClient;
249253
const data = new RawData();
250254
data.setJsondata(JSON.stringify(config, null, 2));
251255
return new Promise<void>((resolve, reject) => {

0 commit comments

Comments
 (0)
Please sign in to comment.