chopped up the FE contribution

Signed-off-by: Akos Kitta <kittaakos@typefox.io>

Author: Akos Kitta

arduino-ide-extension/src/browser/arduino-commands.ts

@@ -24,44 +24,17 @@ export namespace ArduinoCommands {
         id: 'arduino-toggle-compile-for-debug'
     };
 
-    export const SHOW_OPEN_CONTEXT_MENU: Command = {
-        id: 'arduino-show-open-context-menu',
-        label: 'Open Sketch',
-        category
-    };
-
     export const OPEN_FILE_NAVIGATOR: Command = {
         id: 'arduino-open-file-navigator'
     };
 
-    export const OPEN_SKETCH: Command = {
-        id: 'arduino-open-file'
-    };
-
     /**
      * Unlike `OPEN_SKETCH`, it opens all files from a sketch folder. (ino, cpp, etc...)
      */
     export const OPEN_SKETCH_FILES: Command = {
         id: 'arduino-open-sketch-files'
     };
 
-    export const SAVE_SKETCH: Command = {
-        id: 'arduino-save-sketch'
-    };
-
-    export const SAVE_SKETCH_AS: Command = {
-        id: 'arduino-save-sketch-as'
-    };
-
-    export const NEW_SKETCH: Command = {
-        id: 'arduino-new-sketch',
-        label: 'New Sketch',
-        category
-    };
-    export const NEW_SKETCH_TOOLBAR: Command = {
-        id: 'arduino-new-sketch-toolbar'
-    };
-
     export const OPEN_BOARDS_DIALOG: Command = {
         id: 'arduino-open-boards-dialog'
     };

arduino-ide-extension/src/browser/arduino-frontend-contribution.tsx

@@ -1,28 +1,24 @@
 import * as React from 'react';
-import * as dateFormat from 'dateformat';
-import { remote } from 'electron';
 import { injectable, inject, postConstruct } from 'inversify';
 import URI from '@theia/core/lib/common/uri';
 import { EditorWidget } from '@theia/editor/lib/browser/editor-widget';
 import { MessageService } from '@theia/core/lib/common/message-service';
 import { CommandContribution, CommandRegistry, Command, CommandHandler } from '@theia/core/lib/common/command';
 import { TabBarToolbarContribution, TabBarToolbarRegistry } from '@theia/core/lib/browser/shell/tab-bar-toolbar';
-import { BoardsService, BoardsServiceClient, CoreService, Sketch, SketchesService, ToolOutputServiceClient } from '../common/protocol';
+import { BoardsService, BoardsServiceClient, CoreService, SketchesService, ToolOutputServiceClient } from '../common/protocol';
 import { ArduinoCommands } from './arduino-commands';
 import { BoardsServiceClientImpl } from './boards/boards-service-client-impl';
 import { WorkspaceCommands } from '@theia/workspace/lib/browser/workspace-commands';
-import { SelectionService, MenuContribution, MenuModelRegistry, MAIN_MENU_BAR, MenuPath, notEmpty } from '@theia/core';
+import { SelectionService, MenuContribution, MenuModelRegistry, MAIN_MENU_BAR, MenuPath } from '@theia/core';
 import { ArduinoToolbar } from './toolbar/arduino-toolbar';
 import { EditorManager, EditorMainMenu } from '@theia/editor/lib/browser';
 import {
-    ContextMenuRenderer, Widget, StatusBar, StatusBarAlignment, FrontendApplicationContribution,
+    ContextMenuRenderer, StatusBar, StatusBarAlignment, FrontendApplicationContribution,
     FrontendApplication, KeybindingContribution, KeybindingRegistry, OpenerService, open
 } from '@theia/core/lib/browser';
 import { OpenFileDialogProps, FileDialogService } from '@theia/filesystem/lib/browser/file-dialog';
 import { FileSystem, FileStat } from '@theia/filesystem/lib/common';
 import { CommonCommands, CommonMenus } from '@theia/core/lib/browser/common-frontend-contribution';
-import { FileSystemCommands } from '@theia/filesystem/lib/browser/filesystem-frontend-contribution';
-import { FileDownloadCommands } from '@theia/filesystem/lib/browser/download/file-download-command-contribution';
 import { MonacoMenus } from '@theia/monaco/lib/browser/monaco-menu';
 import { TerminalMenus } from '@theia/terminal/lib/browser/terminal-frontend-contribution';
 import { MaybePromise } from '@theia/core/lib/common/types';
@@ -47,6 +43,7 @@ import { ConfigService } from '../common/protocol/config-service';
 import { BoardsConfigStore } from './boards/boards-config-store';
 import { MainMenuManager } from './menu/main-menu-manager';
 import { FileSystemExt } from '../common/protocol/filesystem-ext';
+import { OpenSketch } from './contributions/open-sketch';
 
 export namespace ArduinoMenus {
     export const SKETCH = [...MAIN_MENU_BAR, '3_sketch'];
@@ -209,24 +206,6 @@ export class ArduinoFrontendContribution implements FrontendApplicationContribut
             tooltip: 'Upload',
             priority: 2
         });
-        registry.registerItem({
-            id: ArduinoCommands.NEW_SKETCH.id,
-            command: ArduinoCommands.NEW_SKETCH_TOOLBAR.id,
-            tooltip: 'New',
-            priority: 4 // Note: priority 3 was reserved by debug.
-        });
-        registry.registerItem({
-            id: ArduinoCommands.SHOW_OPEN_CONTEXT_MENU.id,
-            command: ArduinoCommands.SHOW_OPEN_CONTEXT_MENU.id,
-            tooltip: 'Open',
-            priority: 5
-        });
-        registry.registerItem({
-            id: ArduinoCommands.SAVE_SKETCH.id,
-            command: ArduinoCommands.SAVE_SKETCH.id,
-            tooltip: 'Save',
-            priority: 6
-        });
         registry.registerItem({
             id: BoardsToolBarItem.TOOLBAR_ID,
             render: () => <BoardsToolBarItem
@@ -308,101 +287,16 @@ export class ArduinoFrontendContribution implements FrontendApplicationContribut
             execute: this.upload.bind(this)
         });
 
-        registry.registerCommand(ArduinoCommands.SHOW_OPEN_CONTEXT_MENU, {
-            isVisible: widget => ArduinoToolbar.is(widget) && widget.side === 'left',
-            execute: async (widget: Widget, target: EventTarget) => {
-                if (this.wsSketchCount) {
-                    const el = (target as HTMLElement).parentElement;
-                    if (el) {
-                        this.contextMenuRenderer.render(ArduinoToolbarContextMenu.OPEN_SKETCH_PATH, {
-                            x: el.getBoundingClientRect().left,
-                            y: el.getBoundingClientRect().top + el.offsetHeight
-                        });
-                    }
-                } else {
-                    this.commandRegistry.executeCommand(ArduinoCommands.OPEN_FILE_NAVIGATOR.id);
-                }
-            }
-        });
-
         registry.registerCommand(ArduinoCommands.OPEN_FILE_NAVIGATOR, {
             execute: () => this.doOpenFile()
         });
 
-        registry.registerCommand(ArduinoCommands.OPEN_SKETCH, {
-            execute: async (sketch: Sketch) => {
-                this.workspaceService.open(new URI(sketch.uri));
-            }
-        });
-
         registry.registerCommand(ArduinoCommands.OPEN_SKETCH_FILES, {
             execute: async (uri: string) => {
                 this.openSketchFiles(uri);
             }
         });
 
-        registry.registerCommand(ArduinoCommands.SAVE_SKETCH, {
-            isVisible: widget => ArduinoToolbar.is(widget) && widget.side === 'left',
-            execute: (sketch: Sketch) => {
-                registry.executeCommand(CommonCommands.SAVE_ALL.id);
-            }
-        });
-
-        registry.registerCommand(ArduinoCommands.SAVE_SKETCH_AS, {
-            execute: async ({ execOnlyIfTemp }: { execOnlyIfTemp: boolean } = { execOnlyIfTemp: false }) => {
-                const sketches = (await Promise.all(this.workspaceService.tryGetRoots().map(({ uri }) => this.sketchService.getSketchFolder(uri)))).filter(notEmpty);
-                if (!sketches.length) {
-                    return;
-                }
-                if (sketches.length > 1) {
-                    console.log(`Multiple sketch folders were found in the workspace. Falling back to the first one. Sketch folders: ${JSON.stringify(sketches)}`);
-                }
-                const sketch = sketches[0];
-                const isTemp = await this.sketchService.isTemp(sketch);
-                if (!isTemp && !!execOnlyIfTemp) {
-                    return;
-                }
-
-                // If target does not exist, propose a `directories.user`/${sketch.name} path
-                // If target exists, propose `directories.user`/${sketch.name}_copy_${yyyymmddHHMMss}
-                const sketchDirUri = new URI((await this.configService.getConfiguration()).sketchDirUri);
-                const exists = await this.fileSystem.exists(sketchDirUri.resolve(sketch.name).toString());
-                const defaultUri = exists
-                    ? sketchDirUri.resolve(sketchDirUri.resolve(`${sketch.name}_copy_${dateFormat(new Date(), 'yyyymmddHHMMss')}`).toString())
-                    : sketchDirUri.resolve(sketch.name);
-                const defaultPath = await this.fileSystem.getFsPath(defaultUri.toString())!;
-                const { filePath, canceled } = await remote.dialog.showSaveDialog({ title: 'Save sketch folder as...', defaultPath });
-                if (!filePath || canceled) {
-                    return;
-                }
-                const destinationUri = await this.fileSystemExt.getUri(filePath);
-                if (!destinationUri) {
-                    return;
-                }
-                const workspaceUri = await this.sketchService.copy(sketch, { destinationUri });
-                if (workspaceUri) {
-                    this.workspaceService.open(new URI(workspaceUri));
-                }
-            }
-        });
-
-        registry.registerCommand(ArduinoCommands.NEW_SKETCH, {
-            execute: async () => {
-                try {
-                    const sketch = await this.sketchService.createNewSketch();
-                    this.workspaceService.open(new URI(sketch.uri));
-                } catch (e) {
-                    await this.messageService.error(e.toString());
-                }
-            }
-        });
-        registry.registerCommand(ArduinoCommands.NEW_SKETCH_TOOLBAR, {
-            isVisible: widget => ArduinoToolbar.is(widget) && widget.side === 'left',
-            execute: async () => {
-                return registry.executeCommand(ArduinoCommands.NEW_SKETCH.id);
-            }
-        });
-
         registry.registerCommand(ArduinoCommands.OPEN_BOARDS_DIALOG, {
             execute: async () => {
                 const boardsConfig = await this.boardsConfigDialog.open();
@@ -516,17 +410,18 @@ export class ArduinoFrontendContribution implements FrontendApplicationContribut
                 CommonCommands.TOGGLE_MAXIMIZED,
                 FileNavigatorCommands.REVEAL_IN_NAVIGATOR
             ]) {
-                registry.unregisterMenuAction(command);
+                if (command) { }
+                // registry.unregisterMenuAction(command);
             }
 
-            registry.unregisterMenuAction(FileSystemCommands.UPLOAD);
-            registry.unregisterMenuAction(FileDownloadCommands.DOWNLOAD);
+            // registry.unregisterMenuAction(FileSystemCommands.UPLOAD);
+            // registry.unregisterMenuAction(FileDownloadCommands.DOWNLOAD);
 
-            registry.unregisterMenuAction(WorkspaceCommands.OPEN_FOLDER);
-            registry.unregisterMenuAction(WorkspaceCommands.OPEN_WORKSPACE);
-            registry.unregisterMenuAction(WorkspaceCommands.OPEN_RECENT_WORKSPACE);
-            registry.unregisterMenuAction(WorkspaceCommands.SAVE_WORKSPACE_AS);
-            registry.unregisterMenuAction(WorkspaceCommands.CLOSE);
+            // registry.unregisterMenuAction(WorkspaceCommands.OPEN_FOLDER);
+            // registry.unregisterMenuAction(WorkspaceCommands.OPEN_WORKSPACE);
+            // registry.unregisterMenuAction(WorkspaceCommands.OPEN_RECENT_WORKSPACE);
+            // registry.unregisterMenuAction(WorkspaceCommands.SAVE_WORKSPACE_AS);
+            // registry.unregisterMenuAction(WorkspaceCommands.CLOSE);
 
             registry.getMenu(MAIN_MENU_BAR).removeNode(this.getMenuId(MonacoMenus.SELECTION));
             registry.getMenu(MAIN_MENU_BAR).removeNode(this.getMenuId(EditorMainMenu.GO));
@@ -549,10 +444,6 @@ export class ArduinoFrontendContribution implements FrontendApplicationContribut
             label: 'Upload',
             order: '3'
         });
-        registry.registerMenuAction(ArduinoToolbarContextMenu.OPEN_GROUP, {
-            commandId: ArduinoCommands.OPEN_FILE_NAVIGATOR.id,
-            label: 'Open...'
-        });
 
         registry.registerSubmenu(ArduinoMenus.TOOLS, 'Tools');
 
@@ -561,18 +452,10 @@ export class ArduinoFrontendContribution implements FrontendApplicationContribut
             label: 'Advanced Mode'
         });
 
-        registry.registerMenuAction([...CommonMenus.FILE, '0_new_sketch'], {
-            commandId: ArduinoCommands.NEW_SKETCH.id
-        });
-
         registry.registerMenuAction([...CommonMenus.FILE_SETTINGS_SUBMENU, '3_settings_cli'], {
             commandId: ArduinoCommands.OPEN_CLI_CONFIG.id
         });
 
-        registry.registerMenuAction(CommonMenus.FILE_SAVE, {
-            commandId: ArduinoCommands.SAVE_SKETCH_AS.id,
-            label: 'Save As...'
-        });
     }
 
     protected getMenuId(menuPath: string[]): string {
@@ -591,14 +474,6 @@ export class ArduinoFrontendContribution implements FrontendApplicationContribut
             command: ArduinoCommands.UPLOAD.id,
             keybinding: 'CtrlCmd+Alt+U'
         });
-        keybindings.registerKeybinding({
-            command: ArduinoCommands.NEW_SKETCH.id,
-            keybinding: 'CtrlCmd+N'
-        });
-        keybindings.registerKeybinding({
-            command: ArduinoCommands.SAVE_SKETCH_AS.id,
-            keybinding: 'CtrlCmd+Shift+S'
-        });
     }
 
     protected async registerSketchesInMenu(registry: MenuModelRegistry): Promise<void> {
@@ -609,7 +484,7 @@ export class ArduinoFrontendContribution implements FrontendApplicationContribut
                 id: 'openSketch' + sketch.name
             }
             this.commandRegistry.registerCommand(command, {
-                execute: () => this.commandRegistry.executeCommand(ArduinoCommands.OPEN_SKETCH.id, sketch)
+                execute: () => this.commandRegistry.executeCommand(OpenSketch.Commands.OPEN_SKETCH.id, sketch)
             });
 
             registry.registerMenuAction(ArduinoToolbarContextMenu.WS_SKETCHES_GROUP, {

arduino-ide-extension/src/browser/arduino-ide-frontend-module.ts

@@ -79,6 +79,12 @@ import { ILogger } from '@theia/core';
 import { FileSystemExt, FileSystemExtPath } from '../common/protocol/filesystem-ext';
 import { WorkspaceFrontendContribution, FileMenuContribution } from '@theia/workspace/lib/browser';
 import { ArduinoWorkspaceFrontendContribution, ArduinoFileMenuContribution } from './customization/arduino-workspace-frontend-contribution';
+import { Contribution } from './contributions/contribution';
+import { NewSketch } from './contributions/new-sketch';
+import { OpenSketch } from './contributions/open-sketch';
+import { CloseSketch } from './contributions/close-sketch';
+import { SaveAsSketch } from './contributions/save-as-sketch';
+import { SaveSketch } from './contributions/save-sketch';
 
 const ElementQueries = require('css-element-queries/src/ElementQueries');
 
@@ -298,4 +304,10 @@ export default new ContainerModule((bind: interfaces.Bind, unbind: interfaces.Un
 
     // File-system extension
     bind(FileSystemExt).toDynamicValue(context => WebSocketConnectionProvider.createProxy(context.container, FileSystemExtPath)).inSingletonScope();
+
+    Contribution.configure(bind, NewSketch);
+    Contribution.configure(bind, OpenSketch);
+    Contribution.configure(bind, CloseSketch);
+    Contribution.configure(bind, SaveSketch);
+    Contribution.configure(bind, SaveAsSketch);
 });

arduino-ide-extension/src/browser/contributions/close-sketch.ts

@@ -0,0 +1,49 @@
+import { injectable } from 'inversify';
+import { WorkspaceCommands } from '@theia/workspace/lib/browser/workspace-commands';
+import { ArduinoMenus } from '../menu/arduino-menus';
+import { SketchContribution, Command, CommandRegistry, MenuModelRegistry, KeybindingRegistry } from './contribution';
+import { SaveAsSketch } from './save-as-sketch';
+
+@injectable()
+export class CloseSketch extends SketchContribution {
+
+    registerCommands(registry: CommandRegistry): void {
+        registry.registerCommand(CloseSketch.Commands.CLOSE_SKETCH, {
+            execute: async () => {
+                const sketch = await this.getCurrentSketch();
+                if (!sketch) {
+                    return;
+                }
+                const isTemp = await this.sketchService.isTemp(sketch);
+                if (isTemp) {
+                    await this.commandService.executeCommand(SaveAsSketch.Commands.SAVE_AS_SKETCH.id, { openAfterMove: false, execOnlyIfTemp: true });
+                    await this.commandService.executeCommand(WorkspaceCommands.CLOSE.id);
+                }
+            }
+        });
+    }
+
+    registerMenus(registry: MenuModelRegistry): void {
+        registry.registerMenuAction(ArduinoMenus.FILE__SKETCH_GROUP, {
+            commandId: CloseSketch.Commands.CLOSE_SKETCH.id,
+            label: 'Close',
+            order: '5'
+        });
+    }
+
+    registerKeybindings(registry: KeybindingRegistry): void {
+        registry.registerKeybinding({
+            command: CloseSketch.Commands.CLOSE_SKETCH.id,
+            keybinding: 'CtrlCmd+W' // TODO: Windows binding?
+        });
+    }
+
+}
+
+export namespace CloseSketch {
+    export namespace Commands {
+        export const CLOSE_SKETCH: Command = {
+            id: 'arduino-close-sketch'
+        };
+    }
+}