Skip to content

Remove magic numbers from Tone() examples #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove magic numbers from Tone() examples #64

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d5f1af
Update toneMelody.ino
krekr Jun 22, 2023
569885b
Update toneKeyboard.ino
krekr Jun 22, 2023
d751d0b
Update tonePitchFollower.ino
krekr Jun 22, 2023
af1d7e4
Update toneMultiple.ino
krekr Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update toneKeyboard.ino
  • Loading branch information
@krekr
krekr authored Jun 22, 2023
commit 569885ba613109337ed2952f4387714a04516fdf
4 changes: 3 additions & 1 deletion examples/02.Digital/toneKeyboard/toneKeyboard.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

#include "pitches.h"

int buzzerPin = 8;

const int threshold = 10; // minimum reading of the sensors that generates a note

// notes to play, corresponding to the 3 sensors:
Expand All @@ -37,7 +39,7 @@ void loop() {
// if the sensor is pressed hard enough:
if (sensorReading > threshold) {
// play the note corresponding to this sensor:
tone(8, notes[thisSensor], 20);
tone(buzzerPin, notes[thisSensor], 20);
}
}
}