From 557be8f3915b0ab9d1adb01d3d247030a6f90f17 Mon Sep 17 00:00:00 2001
From: per1234 <accounts@perglass.com>
Date: Mon, 2 Aug 2021 14:02:14 -0700
Subject: [PATCH 1/2] Enable `pulseIn()` sketches for Portenta in sketch
 compilation workflow

At the time the "Compile Examples" CI workflow was written, the Portenta H7 board did not have a `pulseIn()` function.
Although this was a legitimate bug, since this was an issue with the `arduino/ArduinoCore-mbed` code base, already
tracked there, and unrelated to the code hosted in this repository, it was determined that the best approach would be to
configure the workflow to not compile the examples that used `pulseIn()` for the Portenta H7.

Since that time, `pulseIn()` has been implemented for Portenta H7 and so we can now compile these sketches for that board.
---
 .github/workflows/compile-examples.yml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml
index c86ff0e..7785ed3 100644
--- a/.github/workflows/compile-examples.yml
+++ b/.github/workflows/compile-examples.yml
@@ -132,9 +132,7 @@ jobs:
             serial1: true
             starter-kit: false
             tone: true
-            # Bug report: https://github.com/arduino/ArduinoCore-mbed/issues/48
-            # Change the value to true once it is fixed.
-            pulsein: false
+            pulsein: true
           - fqbn: arduino:sam:arduino_due_x
             usb: true
             serial1: true

From faac875de4a3bae5291cc8c23427e2349421eac3 Mon Sep 17 00:00:00 2001
From: per1234 <accounts@perglass.com>
Date: Mon, 2 Aug 2021 14:07:49 -0700
Subject: [PATCH 2/2] Remove "pulsein" board attribute from "Compile Examples"
 CI workflow

This attribute was used to configure the workflow to skip compilation of examples that used `pulseIn()` for boards that
were already known to not provide this functionality.

The only such board was the Portenta H7 and that has since gained a `pulseIn()`. Since all boards now have `pulseIn()`,
the attribute no longer serves a purpose and can be removed from the workflow.
---
 .github/workflows/compile-examples.yml | 20 +-------------------
 1 file changed, 1 insertion(+), 19 deletions(-)

diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml
index 7785ed3..a62d862 100644
--- a/.github/workflows/compile-examples.yml
+++ b/.github/workflows/compile-examples.yml
@@ -78,8 +78,7 @@ jobs:
         - examples/04.Communication/SerialEvent
         - examples/04.Communication/VirtualColorMixer
         - examples/05.Control
-        - examples/06.Sensors/ADXL3xx
-        - examples/06.Sensors/Knock
+        - examples/06.Sensors
         - examples/07.Display
         - examples/08.Strings
         - examples/11.ArduinoISP
@@ -95,44 +94,37 @@ jobs:
             serial1: false
             starter-kit: true
             tone: true
-            pulsein: true
           # Adding this in addition to the Uno because it has 1.5 kB less available flash
           - fqbn: arduino:avr:nano
             usb: false
             serial1: false
             starter-kit: false
             tone: true
-            pulsein: true
           - fqbn: arduino:avr:leonardo
             usb: true
             serial1: true
             starter-kit: false
             tone: true
-            pulsein: true
           - fqbn: arduino:megaavr:uno2018:mode=off
             usb: false
             serial1: true
             starter-kit: false
             tone: true
-            pulsein: true
           - fqbn: arduino:samd:mkrzero
             usb: true
             serial1: true
             starter-kit: false
             tone: true
-            pulsein: true
           - fqbn: arduino:mbed_nano:nano33ble
             usb: false
             serial1: true
             starter-kit: false
             tone: true
-            pulsein: true
           - fqbn: arduino:mbed_portenta:envie_m7
             usb: false
             serial1: true
             starter-kit: false
             tone: true
-            pulsein: true
           - fqbn: arduino:sam:arduino_due_x
             usb: true
             serial1: true
@@ -140,7 +132,6 @@ jobs:
             # Bug report: https://github.com/arduino/ArduinoCore-sam/issues/24
             # Change the value to true once it is fixed.
             tone: false
-            pulsein: true
 
         # Make board type-specific customizations to the matrix jobs
         include:
@@ -184,14 +175,6 @@ jobs:
           - board:
               tone: false
             tone-sketch-paths: ""
-          - board:
-              pulsein: true
-            pulsein-sketch-paths: |
-              - examples/06.Sensors/Memsic2125
-              - examples/06.Sensors/Ping
-          - board:
-              pulsein: false
-            pulsein-sketch-paths: ""
 
     steps:
       - name: Checkout
@@ -210,4 +193,3 @@ jobs:
             ${{ matrix.serial1-sketch-paths }}
             ${{ matrix.starter-kit-sketch-paths }}
             ${{ matrix.tone-sketch-paths }}
-            ${{ matrix.pulsein-sketch-paths }}