Skip to content

Commit c0345ea

Browse files
hongthiet1994me-no-dev
authored andcommitted
fix missing the first bit in HC589 shift in (espressif#2448)
1 parent 71ec3c3 commit c0345ea

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

Diff for: cores/esp32/wiring_shift.c

+2-1
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,12 @@ uint8_t shiftIn(uint8_t dataPin, uint8_t clockPin, uint8_t bitOrder) {
2525
uint8_t i;
2626

2727
for(i = 0; i < 8; ++i) {
28-
digitalWrite(clockPin, HIGH);
28+
//digitalWrite(clockPin, HIGH);
2929
if(bitOrder == LSBFIRST)
3030
value |= digitalRead(dataPin) << i;
3131
else
3232
value |= digitalRead(dataPin) << (7 - i);
33+
digitalWrite(clockPin, HIGH);
3334
digitalWrite(clockPin, LOW);
3435
}
3536
return value;

0 commit comments

Comments
 (0)