From 47be11c542419462f8506f424b8009f4eb321476 Mon Sep 17 00:00:00 2001 From: Sandeep Mistry Date: Thu, 12 May 2016 17:24:45 -0400 Subject: [PATCH 1/2] Only check command signature in non-network mode Signed-off-by: Sandeep Mistry --- conn.go | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/conn.go b/conn.go index 50a552cd0..d0b580ee8 100644 --- a/conn.go +++ b/conn.go @@ -74,12 +74,17 @@ func uploadHandler(c *gin.Context) { return } - if data.Signature == "" { - c.String(http.StatusBadRequest, "signature is required") - return - } + if data.Extra.Network == false { + if data.Signature == "" { + c.String(http.StatusBadRequest, "signature is required") + return + } + + if data.Commandline == "" { + c.String(http.StatusBadRequest, "commandline is required for local board") + return + } - if data.Extra.Network { err := verifyCommandLine(data.Commandline, data.Signature) if err != nil { @@ -88,11 +93,6 @@ func uploadHandler(c *gin.Context) { } } - if data.Extra.Network == false && data.Commandline == "" { - c.String(http.StatusBadRequest, "commandline is required for local board") - return - } - buffer := bytes.NewBuffer(data.Hex) path, err := saveFileonTempDir(data.Filename, buffer) From 597ff7d31c4bd387618dad753b9387ceec9719e2 Mon Sep 17 00:00:00 2001 From: Sandeep Mistry Date: Thu, 12 May 2016 17:25:13 -0400 Subject: [PATCH 2/2] Add missing return for saveFileonTempDir error --- conn.go | 1 + 1 file changed, 1 insertion(+) diff --git a/conn.go b/conn.go index d0b580ee8..c6a345e57 100644 --- a/conn.go +++ b/conn.go @@ -98,6 +98,7 @@ func uploadHandler(c *gin.Context) { path, err := saveFileonTempDir(data.Filename, buffer) if err != nil { c.String(http.StatusBadRequest, err.Error()) + return } if data.Rewrite != "" {