Only check command signature in non-network mode (#97)

* Only check command signature in non-network mode

Signed-off-by: Sandeep Mistry <s.mistry@arduino.cc>

* Add missing return for saveFileonTempDir error

Author: sandeepmistry

conn.go

@@ -74,12 +74,17 @@ func uploadHandler(c *gin.Context) {
 		return
 	}
 
-	if data.Signature == "" {
-		c.String(http.StatusBadRequest, "signature is required")
-		return
-	}
+	if data.Extra.Network == false {
+		if data.Signature == "" {
+			c.String(http.StatusBadRequest, "signature is required")
+			return
+		}
+
+		if data.Commandline == "" {
+			c.String(http.StatusBadRequest, "commandline is required for local board")
+			return
+		}
 
-	if data.Extra.Network {
 		err := verifyCommandLine(data.Commandline, data.Signature)
 
 		if err != nil {
@@ -88,16 +93,12 @@ func uploadHandler(c *gin.Context) {
 		}
 	}
 
-	if data.Extra.Network == false && data.Commandline == "" {
-		c.String(http.StatusBadRequest, "commandline is required for local board")
-		return
-	}
-
 	buffer := bytes.NewBuffer(data.Hex)
 
 	path, err := saveFileonTempDir(data.Filename, buffer)
 	if err != nil {
 		c.String(http.StatusBadRequest, err.Error())
+		return
 	}
 
 	if data.Rewrite != "" {