Refactoring rxjs #8
Conversation
Added testing page + started refactoring with RXJS
src/reader-writer.js
Outdated
| jsonMessage = JSON.parse(message); | ||
| } | ||
| catch (SyntaxError) { | ||
| return; |
There was a problem hiding this comment.
Is it worth emitting a parse error for log/debug/error-displaying purpose?
src/socket-daemon.js
Outdated
| export const AGENT_STATUS_CONNECTED = 'AGENT_CONNECTED'; | ||
| export const AGENT_STATUS_DISCONNECTED = 'AGENT_DISCONNECTED'; | ||
| export const AGENT_STATUS_FOUND = 'AGENT_FOUND'; | ||
| export const AGENT_STATUS_NOT_FOUND = 'AGENT_NOT_FOUND'; |
src/socket-daemon.js
Outdated
|
|
||
| this.readerWriter = new ReaderWriter(); | ||
| this.wsConnectionStatus.subscribe(status => { | ||
| if (status === WS_STATUS_CONNECTED) { |
There was a problem hiding this comment.
I would suggest to replace the if with the RxJS filter operator like:
this.wsConnectionStatus
.filter(status => status === WS_STATUS_CONNECTED)
.subscribe(status => {
this.readerWriter.initSocket(this.socket)
});
| "detect-browser": "^2.5.1", | ||
| "rxjs": "^6.2.1", | ||
| "semver-compare": "^1.0.0", | ||
| "socket.io-client": "1.7.4" |
There was a problem hiding this comment.
Check if it's worth to move from "native" socket.io-client to https://www.npmjs.com/package/rxjs-socket.io
destegabry
left a comment
destegabry
left a comment
There was a problem hiding this comment.
I tested the web app locally (but I have not any device to test listing), seems working to me, I just added some comments to improve the usage of rxjs
src/reader-writer.js
Outdated
| data = JSON.parse(message); | ||
| } | ||
| catch (SyntaxError) { | ||
| return; |
There was a problem hiding this comment.
Is it worth emitting a parse error for log/debug/error-displaying purpose?
src/socket-daemon.js
Outdated
| }) | ||
| .finally(() => { | ||
| if (!this.isConnected()) { | ||
| setTimeout(find, 3000); |
There was a problem hiding this comment.
Please move to rxjs interval, using observables to launch it:
- when agent is disconnected socket polling should be disabled and agent polling should be started
- when agent is connected socket polling should be started and agent polling should be disabled
… as message subject
…-communication into refactoring-rxjs
…-communication into refactoring-rxjs
…-communication into refactoring-rxjs
…-communication into refactoring-rxjs
3 participants
No description provided.