This repository was archived by the owner on Mar 27, 2025. It is now read-only.
[APGFL-58] Binary .sig verify #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 15, 2019 17:51
…ass "Shared-DevOps/create builder-api sketch and commands signing rsa key" pub key
matteosuppo
approved these changes
Feb 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sketch binaries signature (sha256 + VerifyPKCS1v15) verification for the /upload MQTT command:
signature is performed using builder private key ("Shared-DevOps/create builder-api sketch and commands signing rsa key") set as default flag value
proper integ testing for signature verification using signed binaries