Skip to content
This repository was archived by the owner on Mar 27, 2025. It is now read-only.

Conversation

@pippolo84
Copy link

The purpose of this PR is to clearly separate the two classes of tests in the project.

Integration tests requires the interaction with an aws iot mqtt broker, while functional tests relies on a mqtt broker running in a docker container.

Using the build tags "integration" and "functional", respectively, we can clearly separate the code for the tests. Besides, we can run the proper global setup code (see TestMain in handlers_containers_functional_test.go) for the specific class of test we want to execute.

Using the build tags "integration" and "functional" we separate the two
class of tests.
@pippolo84 pippolo84 requested review from guerinoni and rsora July 24, 2020 15:09
@pippolo84 pippolo84 self-assigned this Jul 24, 2020
Copy link
Contributor

@guerinoni guerinoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@guerinoni guerinoni merged commit 1e84435 into master Aug 3, 2020
@guerinoni guerinoni deleted the integration-functional-build-tags branch August 4, 2020 08:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants